security: add SHA-256 integrity check for downloaded docker-compose file#540
Closed
TerminalsandCoffee wants to merge 1 commit intoSuperClaude-Org:masterfrom
Closed
Conversation
The AIRIS MCP Gateway installer downloads a docker-compose.yml from a raw GitHub URL and immediately executes it via docker compose up with no integrity verification. If the upstream repo is compromised, arbitrary containers run on the user's machine with host filesystem access. This change: - Adds SHA-256 hash verification after downloading docker-compose.dist.yml - Aborts installation and deletes the file if the hash doesn't match - Prints expected vs actual hash for debugging The hash must be updated when the upstream docker-compose.dist.yml is intentionally changed. Fixes #537 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds SHA-256 hash verification for the docker-compose.dist.yml file downloaded during AIRIS MCP Gateway installation, preventing execution of tampered compose files.
Fixes #537
Problem
The installer downloads
docker-compose.dist.ymlfrom a raw GitHub URL and immediately runsdocker compose up -d— with no checksum, no signature, and no pinned commit. If the upstream repo is compromised, arbitrary containers execute on the user's machine with host filesystem access (via${PWD}read-write mounts).Changes
hashlibimportEXPECTED_COMPOSE_HASH) must be updated when the upstream compose file is intentionally changedTest plan
🤖 Generated with Claude Code