Fix ArbGasInfoShim compliance: Selectors, Return Values, and Missing Methods#8
Merged
Merged
Conversation
…TxL1GasFees tests
…tibility + updated arbgas deployedByteCode
… and integration checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR consolidates fixes for several critical bugs regarding the
ArbGasInfoShimprecompile compatibility. It aligns the shim implementation with the official ArbitrumArbGasInfointerface, ensuring that function selectors, return values, and tuple mappings are correct for local development environments.Related Issues
Closes #4
Closes #5
Closes #6
Closes #7
Changes Made
getL1BaseFeeEstimateandgetCurrentTxL1GasFeesare recognized).ArbGasInfoShimmissing standardArbGasInfomethods #5): Implemented standardArbGasInfomethods that were previously missing from the shim, preventing "function not found" errors in standard tooling.ArbGasInfointerface (returninguint256where expected instead of incompatible types).nitroToShimTuplelogic to correctly map the return values from the internal emulation to the output buffer.Verification
scripts/validate-arbgas.js.getL1BaseFeeEstimateandgetCurrentTxL1GasFeesreturn valid values (0 for local dev) without reverting.