fix(writer): satisfy CodeQL mixed-returns on build_bundle#137
Merged
Conversation
Make the trailing assert_never an explicit `return assert_never(...)` so py/mixed-returns no longer flags build_bundle. assert_never is typed NoReturn, so mypy still accepts the return; this is a pure style fix to quiet CodeQL alert #12. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
assert_never(cfg.distro)inbuild_bundletoreturn assert_never(cfg.distro)so CodeQL no longer flagspy/mixed-returns(alert ks-gen verify: detect tailoring drift (workstation host.yaml vs. /root/tailoring.xml) #12).assert_neveris typedNoReturn, so mypy still accepts the return — pure style fix, no behavior change.src/ks_gen/rules/_types.py).Test plan
ruff check src tests && ruff format --check src tests && mypy && pytest -q— green locally (963 passed)