Rework journeys - #588
Merged
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughAdds Journeys analytics endpoints and ClickHouse queries, replaces User Flow API usage, introduces a Journeys Sankey dashboard with session drilldown, and updates related documentation and translations. ChangesJourneys analytics
Estimated code review effort: 4 (Complex) | ~60 minutes Sequence Diagram(s)sequenceDiagram
participant User
participant JourneysView
participant AnalyticsProxy
participant AnalyticsAPI
participant AnalyticsService
participant ClickHouse
User->>JourneysView: Select Journeys tab and filters
JourneysView->>AnalyticsProxy: Fetch journey paths
AnalyticsProxy->>AnalyticsAPI: Submit getJourneys request
AnalyticsAPI->>AnalyticsService: Query journey analytics
AnalyticsService->>ClickHouse: Execute page-path aggregation
ClickHouse-->>AnalyticsService: Return journey paths and counts
AnalyticsService-->>JourneysView: Render Sankey chart
User->>JourneysView: Select a journey node
JourneysView->>AnalyticsProxy: Fetch journey sessions
AnalyticsProxy->>AnalyticsAPI: Submit getJourneySessions request
AnalyticsAPI->>AnalyticsService: Query matching sessions
AnalyticsService->>ClickHouse: Execute session detail query
ClickHouse-->>JourneysView: Return paginated sessions
Possibly related PRs
🚥 Pre-merge checks | ✅ 2 | ❌ 3❌ Failed checks (2 warnings, 1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@web/app/pages/Project/tabs/Journeys/JourneysView.tsx`:
- Around line 108-165: Remove the loadingRef guard and its now-unused loadingRef
declaration from the JourneysView effect. Let every dependency change invoke
load() and fetch with the latest parameters; retain the cancelled flag to ignore
stale responses and preserve the existing loading state cleanup.
In `@web/public/locales/en.json`:
- Line 2679: Update the `noData` translation string to replace “or you disabled”
with “or you've disabled,” preserving the rest of the message.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 8b27893a-63be-4160-b4e0-2996ecf101df
⛔ Files ignored due to path filters (3)
docs/public/img/analytics-dashboard/journeys-sessions-drawer.pngis excluded by!**/*.pngdocs/public/img/analytics-dashboard/journeys-tooltip.pngis excluded by!**/*.pngdocs/public/img/analytics-dashboard/journeys-view.pngis excluded by!**/*.png
📒 Files selected for processing (26)
backend/apps/cloud/src/analytics/analytics.controller.tsbackend/apps/cloud/src/analytics/analytics.service.tsbackend/apps/cloud/src/analytics/dto/get-journey-sessions.dto.tsbackend/apps/cloud/src/analytics/dto/get-journeys.dto.tsbackend/apps/cloud/src/analytics/interfaces/index.tsbackend/apps/community/src/analytics/analytics.controller.tsbackend/apps/community/src/analytics/analytics.service.tsbackend/apps/community/src/analytics/dto/get-journey-sessions.dto.tsbackend/apps/community/src/analytics/dto/get-journeys.dto.tsbackend/apps/community/src/analytics/interfaces/index.tsdocs/content/docs/analytics-dashboard/journeys.mdxdocs/content/docs/analytics-dashboard/meta.jsondocs/content/docs/analytics-dashboard/traffic.mdxdocs/content/docs/api/stats.mdxweb/app/api/api.server.tsweb/app/hooks/useAnalyticsProxy.tsweb/app/lib/constants/index.tsweb/app/pages/Project/View/ViewProject.helpers.tsxweb/app/pages/Project/View/ViewProject.tsxweb/app/pages/Project/View/components/ProjectSidebar.tsxweb/app/pages/Project/tabs/Journeys/JourneysView.tsxweb/app/pages/Project/tabs/Traffic/SessionsDrawer.tsxweb/app/pages/Project/tabs/Traffic/TrafficView.tsxweb/app/pages/Project/tabs/Traffic/UserFlow.tsxweb/app/routes/api.analytics.tsweb/public/locales/en.json
💤 Files with no reviewable changes (2)
- web/app/pages/Project/tabs/Traffic/UserFlow.tsx
- web/app/pages/Project/View/ViewProject.helpers.tsx
This was referenced Jul 15, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
If applicable, please describe what changes were made in this pull request.
Community Edition support
Database migrations
Documentation
Summary by CodeRabbit