Skip to content

Conversation

@jeffhodsdon
Copy link

Hello! I am a big fan of Swinject and have started to use SwinjectPropertyLoader heavily for configuring many apps using the same assemblers. Big fan of the inheritance via overriding. Since the project has not been updated in 4 years — this is a pull request to get a conversation going to see if any of these changes are of value to be merged into the project.

Changes within this PR—

  1. SPM/Package.swift support with various updates for Swift 6 bring support to iOS 15+
  2. PropertyKey type safe retrieval (identical to Notifications.Name pattern within Apple stdlibs)
  3. TOMLPropertyLoader.
  4. StructPropertyLoader. Uses reflection to set properties.
  5. Loading JSON/Plist/TOML via URL

I am currently using my fork in production and wanted not to keep it to myself. Think this would be great to get this project jumpstarted again. Looking for this PR to be a conversation.

Thanks!

@jeffhodsdon
Copy link
Author

What do you think @yoichitgy ?

@yoichitgy
Copy link
Member

@jeffhodsdon (cc @maxim-chipeev @0xLucasMarcal)
Currently Swinject is maintained by Faire Wholesale Inc.

Copy link

@0xLucasMarcal 0xLucasMarcal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me!
We should cut a new release when the PR gets merged.
Thank you so much for your patience and contribution

@jeffhodsdon
Copy link
Author

@0xLucasMarcal awesome! Thank you! Let me know if there is anything else I can do to help get this merged. Looking forward to helping out with this project in the future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants