feat(cli): get image repository host on login

Author: olevski

renku/core/login.py

@@ -135,6 +135,25 @@ def login(endpoint: Optional[str], git_login: bool, yes: bool):
         else:
             raise errors.AuthenticationError(f"Invalid status code from server: {status_code} - {response.content}")
 
+    image_regsitry_host_req_url = _get_url(parsed_endpoint, path=f"/api/config/imageRegistries")
+    image_registry_host_res = requests.get(image_regsitry_host_req_url)
+    if image_registry_host_res.status_code != 200:
+        raise errors.ConfigurationError(
+            f"Cannot get the image registry host from {image_regsitry_host_req_url}, "
+            f"got unexpected status code {image_registry_host_res.status_code}"
+        )
+    image_registry_host = image_registry_host_res.json().get("default")
+    if not image_registry_host:
+        raise errors.ConfigurationError(
+            f"Cannot get the image registry host from the response {image_registry_host_res.text}"
+        )
+    set_value(
+        section=CONFIG_SECTION,
+        key=f"{parsed_endpoint.netloc}_image_registry_host",
+        value=image_registry_host,
+        global_only=True,
+    )
+
     access_token = response.json().get("access_token")
     _store_token(parsed_endpoint.netloc, access_token)
 

renku/core/session/session.py

@@ -27,7 +27,7 @@
 from renku.core import errors
 from renku.core.config import get_value
 from renku.core.plugin.session import get_supported_session_providers
-from renku.core.session.utils import get_image_repository_host, get_renku_project_name
+from renku.core.session.utils import get_renku_host, get_renku_project_name
 from renku.core.util import communication
 from renku.core.util.os import safe_read_yaml
 from renku.core.util.ssh import SystemSSHConfig, generate_ssh_keys
@@ -125,7 +125,7 @@ def session_start(
     project_name = get_renku_project_name()
     if image_name is None:
         tag = project_context.repository.head.commit.hexsha[:7]
-        repo_host = get_image_repository_host()
+        repo_host = get_value("http", f"{get_renku_host()}_image_registry_host")
         image_name = f"{project_name}:{tag}"
         if repo_host:
             image_name = f"{repo_host}/{image_name}"

renku/core/session/utils.py

@@ -46,13 +46,9 @@ def get_renku_url() -> Optional[str]:
     return renku_url
 
 
-def get_image_repository_host() -> Optional[str]:
-    """Derive the hostname for the gitlab container registry."""
-    # NOTE: Used to circumvent cases where the registry URL is not guessed correctly
-    # remove once #3301 is done
-    if "RENKU_IMAGE_REGISTRY" in os.environ:
-        return os.environ["RENKU_IMAGE_REGISTRY"]
-    renku_url = get_renku_url()
+def get_renku_host() -> Optional[str]:
+    """Derive the URL of the Renku deployment."""
+    renku_url = parse_authentication_endpoint(use_remote=True)
     if not renku_url:
         return None
-    return "registry." + urllib.parse.urlparse(renku_url).netloc
+    return renku_url.netloc

tests/core/models/test_git.py

@@ -296,6 +296,24 @@
             "owner": "renku-test",
             "env": "https://gitlab.example.com",
         },
+        {
+            "href": "https://dev.renku.ch/gitlab/group1/renku-test/test-2022-11-11-17-01-46.git",
+            "scheme": "https",
+            "hostname": "dev.renku.ch",
+            "name": "test-2022-11-11-17-01-46",
+            "path": "gitlab/group1/renku-test/test-2022-11-11-17-01-46.git",
+            "owner": "group1/renku-test",
+            "env": "https://dev.renku.ch/gitlab/",
+        },
+        {
+            "href": "https://gitlab.example.com/group1/group2/renku-test/test-2022-11-11-17-01-46.git",
+            "scheme": "https",
+            "hostname": "gitlab.example.com",
+            "name": "test-2022-11-11-17-01-46",
+            "path": "group1/group2/renku-test/test-2022-11-11-17-01-46.git",
+            "owner": "group1/group2/renku-test",
+            "env": "https://gitlab.example.com",
+        },
     ],
 )
 def test_valid_href(fields):