Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable Xdebug with docker build stage and dc override #433

Draft
wants to merge 3 commits into
base: 1.7
Choose a base branch
from

Conversation

lwillems
Copy link

Hello

To enable Xdebug just add a new stage to DockerFile and load override.
Original credits go to @dunglas with docker sf5 repo

Hope it could be useful.

Regards

@lwillems lwillems requested a review from a team as a code owner October 15, 2020 12:28
@lchrusciel lchrusciel added the Docker Docker-related issues and PRs. label Oct 23, 2020
@lchrusciel
Copy link
Member

Hey Laurent,
thansk for your proposal. However, the build is red. I've restarted it.

@lwillems
Copy link
Author

@lchrusciel
Build seems fail on php memory limit issue ?

@lchrusciel
Copy link
Member

Hey Laurent, we need to wait for the green build of #436. After merging and rebase, we can move on.

@lwillems
Copy link
Author

lwillems commented Nov 1, 2020

@lchrusciel i have fixed a typo issue breaking build with overidde, seems #436 merged ?
Regards

@lchrusciel
Copy link
Member

Hey Laurent, the current issue is related to Docker itself: https://travis-ci.com/github/Sylius/Sylius-Standard/jobs/423497979#L2986

Have you tested the current build on your machine? Do you think, you could fix our build?

@lwillems
Copy link
Author

lwillems commented Nov 9, 2020

Hey Laurent, the current issue is related to Docker itself: https://travis-ci.com/github/Sylius/Sylius-Standard/jobs/423497979#L2986

Have you tested the current build on your machine? Do you think, you could fix our build?

Hi @lchrusciel
After investigations
I think build fails for several reason but the most important one is composer version
Prestissimo package is locked to composer 1 and in your build you are using composer:latest (now is version 2 by default).
I have fixed it with latest version on docker hub : 2.0.4 (latest should do the job but locally it always pull 1.10 on my laptop), also upgraded to php 7.4 and replace prestissimo with flex as suggested by Dunglas in another PR.
Also there is differences between lock and json file, i have updated composer.lock file but there is conflict

Can you resolve conflict with my file (up to date) and relaunch build with latest changes ? it should work, on my local machine it's up and running.

Regards

@lchrusciel
Copy link
Member

Done in separe PR, as I was not able to add something to your branch

@lchrusciel
Copy link
Member

Hey Laurent,

it has been way too long since you received some feedback from us. Is there chance, to rebase this PR?

@Ferror
Copy link
Contributor

Ferror commented May 24, 2022

@lwillems Thank you for your PR!

The PR contains also changed not related to Docker and Xdebug. We are more than happy to merge it, but without additional changes in symfony.lock, composer.lock and some of the Dockerfile changes.

@Ferror Ferror marked this pull request as draft May 31, 2022 14:40
@Ferror Ferror closed this Jul 6, 2022
@Ferror Ferror reopened this Jul 6, 2022
@Ferror
Copy link
Contributor

Ferror commented Jul 6, 2022

Created the development stage in: #781

What's left is to install and configure xdebug

Copy link
Member

@diimpp diimpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Xdebug increases load time for dev env drastically, so it shouldn't be added to sylius_php_dev stage. Idea with docker-compose.debug.yml looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docker Docker-related issues and PRs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants