-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable Xdebug with docker build stage and dc override #433
base: 1.7
Are you sure you want to change the base?
Conversation
Hey Laurent, |
@lchrusciel |
Hey Laurent, we need to wait for the green build of #436. After merging and rebase, we can move on. |
@lchrusciel i have fixed a typo issue breaking build with overidde, seems #436 merged ? |
Hey Laurent, the current issue is related to Docker itself: https://travis-ci.com/github/Sylius/Sylius-Standard/jobs/423497979#L2986 Have you tested the current build on your machine? Do you think, you could fix our build? |
Hi @lchrusciel Can you resolve conflict with my file (up to date) and relaunch build with latest changes ? it should work, on my local machine it's up and running. Regards |
Done in separe PR, as I was not able to add something to your branch |
Hey Laurent, it has been way too long since you received some feedback from us. Is there chance, to rebase this PR? |
@lwillems Thank you for your PR! The PR contains also changed not related to Docker and Xdebug. We are more than happy to merge it, but without additional changes in symfony.lock, composer.lock and some of the Dockerfile changes. |
Created the development stage in: #781 What's left is to install and configure xdebug |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Xdebug increases load time for dev env drastically, so it shouldn't be added to sylius_php_dev
stage. Idea with docker-compose.debug.yml
looks good.
Hello
To enable Xdebug just add a new stage to DockerFile and load override.
Original credits go to @dunglas with docker sf5 repo
Hope it could be useful.
Regards