Fixing the readme example to use z3 and to generate a witness:#140
Open
sohah wants to merge 1 commit intoSymbolicPathFinder:sv-compfrom
Open
Fixing the readme example to use z3 and to generate a witness:#140sohah wants to merge 1 commit intoSymbolicPathFinder:sv-compfrom
sohah wants to merge 1 commit intoSymbolicPathFinder:sv-compfrom
Conversation
1. The default choco solver cannot deal with non-linear arithmetic moreover, choco solver has a bug that which I will open an issue for it. 2. The witness generation requires using Verifier.<something>() or Debug.makeSymbolic<something>(), so it can intercept the particular variable and starts creating the graphml
Author
|
Hi @yannicnoller , do you have any comments on this PR, if not, then can you please accept. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The example in the readme is not working with the current setup. It uses choco, as the default solver. But there are multiple of problems with this. First, choco does not work with non-linear arithemtic, thus this example as it uses a divide operation, is not very nice example for using choco. The other reason is that choco actually is creating a wrong constraint, thus ignoring going deeper into the program, when it backtracks it is able to detect the div by zero, but there is an issue at an earlier point that needs to be addressed. I'll open up an issue with that problem.
This PR makes the following changes
NumericExample.jpfto usez3Verifier.nondetInt()to create the symbolic integer and chaning theNumericExample.jpfaccordingly.NumericExample.java, and clarifying that the program-under-test needs to use specific methods to create symbolic variables for it to trigger the creation of the witness in a graphml format.