Skip to content

Move scattered oredict definitions into oreDict.groovy#1822

Open
Crindigo wants to merge 1 commit intomaster-ceufrom
crindigo/fix-oredicts
Open

Move scattered oredict definitions into oreDict.groovy#1822
Crindigo wants to merge 1 commit intomaster-ceufrom
crindigo/fix-oredicts

Conversation

@Crindigo
Copy link
Contributor

@Crindigo Crindigo commented Mar 7, 2026

What

Fixes issues where some oredicts are used before they are defined, like the rubylith recipe missing mylar.

Outcome

All the oreDict.add calls in postInit/ have been moved into prePostInit/oreDict.groovy and changed to ore(...).add(...) to match the style of the others.

@Crindigo Crindigo added the fix A fix to a bug (used for PRs) label Mar 7, 2026
@Fiery36
Copy link
Contributor

Fiery36 commented Mar 7, 2026

I feel like if they are very specific to a chain it's better to leave them in that file rather than oreDict.groovy. Mainly just the zinc residues in this case, though there's also an argument for the electrolyte fruit.

@Crindigo
Copy link
Contributor Author

Crindigo commented Mar 7, 2026

There's other ore dicts configured in here that would also have to be moved back into separate files, in that case, like the nutrients into GreenhouseChain. Electrolyte fruit could also be reused in a citric acid chain down the road (maybe with a rename). I just don't like the idea of an oredict randomly working or not depending on what file it's in, and they should be universal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix A fix to a bug (used for PRs)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants