Move scattered oredict definitions into oreDict.groovy#1822
Open
Crindigo wants to merge 1 commit intomaster-ceufrom
Open
Move scattered oredict definitions into oreDict.groovy#1822Crindigo wants to merge 1 commit intomaster-ceufrom
Crindigo wants to merge 1 commit intomaster-ceufrom
Conversation
…like mylar being missing from rubylith
Contributor
|
I feel like if they are very specific to a chain it's better to leave them in that file rather than oreDict.groovy. Mainly just the zinc residues in this case, though there's also an argument for the electrolyte fruit. |
Contributor
Author
|
There's other ore dicts configured in here that would also have to be moved back into separate files, in that case, like the nutrients into GreenhouseChain. Electrolyte fruit could also be reused in a citric acid chain down the road (maybe with a rename). I just don't like the idea of an oredict randomly working or not depending on what file it's in, and they should be universal. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes issues where some oredicts are used before they are defined, like the rubylith recipe missing mylar.
Outcome
All the oreDict.add calls in postInit/ have been moved into prePostInit/oreDict.groovy and changed to ore(...).add(...) to match the style of the others.