[DO NOT MERGE] UUPS upgradability for the Sequencing chain contract + deployer #839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
namespaced storage slots are an alternative to gap variables that prevent storage layout conflicts when modifying the base contracts
use struct_link instead of link as the contract storage variable is now a struct field
Previously, signed transactions were represented verbatim, unsigned ones as the unsigned tx type prefix, and compressed ones as null. Now unsigned transactions include the full tx data so that the sequencing module can use it as part of the isAllowed() check. Additionally, signed transactions include the signed transaction type prefix to make them easier to detect, prevent collisions with the other tx types, and allow for new tx types with a different prefix byte to be added in the future. Finally compressed transactions are represented as the compressed tx prefix byte instead of null to prevent reverts when checking the tx type.
* add implementations list and gas ban to the factory, make sequencing contract call back to the factory for upgrades * bindings, e2e upgrade lifecycle test * cleanup * use minimal UUPS for deterministic addresses * update storage layout
…reserve storage slots for future upgrades
* Update storage checks to confirm an empty object * add namespaced storage to GasArchive and Syndicatefactory * make -C shared create-contract-bindings * update storage layout * fix lint
* New gas metering contract used to track how much gas appchains use per epoch * fix test * PR updates and contract bindings * assembly * fix merge mistake * fix certora * certora fix attempt #2 * skip flaky fork test and fix certora syntax * fmt, cerotra fix, and cli fix * one more certora fix * fix cli * fix cli * fix tests * fmt * fmt * updates to fix tests * fix clippy * fix gas estimation issue * fmt
* hardcode version * bindings * fix create-chain abis
…act (#896) * wip * new forwarder for deployment and cleanup factories * delete factory from check * remove factories from create chain * comment out script and add todos * add helper func and some comments
ibremseth
changed the title
* Adding placeholder contract for controlling forwarders * remove unneeded func
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a re-opening of #763 that got closed when the
stagingbranch was deletedTicket
What does this PR do?
SyndicateSequencingChaincontract storage slotsBreaking changes?
Documentation
How can this PR be tested?
forge test