Repository navigation
Add live review visibility: sidebar, finding cards, and stats hotspots - #26
Open
theogrillat wants to merge 24 commits into
Open
theogrillat wants to merge 24 commits into
theogrillat wants to merge 24 commits into
Conversation
Summary-first /pair-stats overlay with detail and refresh controls, a non-capturing top-right status badge that survives hidden footers, and a quieter accepted-finding layout.
ReviewStore.lookup reports a finding's title, line, queued/awaiting/accepted/rejected/discarded status and decision reason.
ReviewFeed keeps the latest 100 reviews newest first with file, short model name, outcome, duration and attributed finding ids.
Framed top-right card rendering each review's outcome and model, with live verdicts and reasons. Paths keep the file name and drop leading directories first; the card sizes to its content above the editor.
Feeds review starts, outcomes and newly admitted findings into the sidebar, refreshes it on every state change, clears it with /pair-clear and session changes, and documents the controls.
Reviews appear while running or once they have accepted or rejected findings; only decided findings are listed, summarized as 'N accepted · N rejected'. No-finding, undecided, failed, timed-out, superseded and cancelled reviews are hidden.
Accepted findings carry structured details and render as a title plus file-name-first location; Pi's expand toggle reveals the evidence and the agent's reason. Older messages and hosts without message renderers keep the default rendering.
Left-clicking a card toggles its evidence and reason, with a ▸/▾ affordance. The toggle survives Pi's component rebuilds and yields to a later global ctrl+o. Requires fullscreen mode, where Pi routes mouse events.
Reviewers accept an optional 1-24 character name (default reviewer: entropy) that labels sidebar rows and accepted cards, falling back to the short model name. Names are not part of reviewer identity.
Each review collapses to one row (file, reviewer, verdict counts ▸); a left click on any of its rows toggles duration, findings and reasons. Expanded reviews that no longer fit fall back to their collapsed row.
Rejections are appended as transcript-only custom entries, so they never reach model context, and render as one dimmed line that expands by click or ctrl+o to location, evidence and reason. Accepted and rejected cards share one finding-card module.
Press h to rank files by accepted findings on the selected branch, with width-scaled bars and rejected counts; o, d and h switch tabs. README documents hotspots and rejected cards.
theogrillat
changed the title
…-stats # Conflicts: # README.md
T-moz
requested changes
Sep 28, 2026
T-moz
left a comment
T-moz
left a comment
Owner
There was a problem hiding this comment.
Please consolidate the duplicated status rules, overlay lifecycle and frame rendering noted inline.
T-moz
requested changes
Sep 28, 2026
T-moz
left a comment
T-moz
left a comment
Owner
There was a problem hiding this comment.
Please fix the sidebar cleanup race and simplify the finding attribution and formatting dependencies noted inline.
T-moz
requested changes
Sep 28, 2026
T-moz
left a comment
T-moz
left a comment
Owner
There was a problem hiding this comment.
The visibility improvements make sense, but please keep rejected findings out of the transcript and make the review feed available to OMP users too.
T-moz
requested changes
Sep 28, 2026
T-moz
left a comment
T-moz
left a comment
Owner
There was a problem hiding this comment.
Please fix the OMP keyboard freeze, Pi overlay dismissal, and Ctrl+O collapse regression noted inline. Reproduced with OMP 18.4.2 and Pi 0.87.1 runtime probes.
…-stats # Conflicts: # src/finding-admission.ts # src/index.ts # src/review-runner.ts
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Pair Programmer reviews run in the background, but it is hard to see what is running, what was decided and why. This PR adds live, non-blocking review visibility while keeping rejected findings out of model context.
What changed
Live review status
watching,reviewing,queued,awaiting decisionorpaused.Review sidebar
/pair-feedandalt+rto toggle a live sidebar of recent reviews./pair-clearand on session changes.Finding cards
ctrl+o.Reviewer names
name(1–24 chars) for the sidebar and cards.entropy./pair-statsd), overview (o), refresh (r) and scrolling controls.h) that ranks files by accepted findings, with rejected counts.Housekeeping
@earendil-works/pi-tuifor the overlays.Testing
npm test— passes, with 100% statement, branch, function and line coverage.npm run typecheck— passes.