Skip to content

Conversation

@SuuperW
Copy link
Contributor

@SuuperW SuuperW commented Oct 18, 2025

Issue fixed:

  1. Set window size to 2x.
  2. Enable A/V capture OSD
  3. Record video with ffmpeg writer, give the name "test.mp4"
  4. Frame advance to actually capture a frame
    Result: The video is written to "test_1.mp4". File "test.mp4" was created but has no video.

This PR fixes the issue by pulling out the logic for acquiring a IVideoProvider that was being used in MainForm.AvFrameAdvance to its own method, and using that method to obtain the initial video resolution.

Check if completed:

@vadosnaprimer vadosnaprimer changed the title Fix video filename Fix video filename with ffmpeg writer Oct 18, 2025
@YoshiRulz YoshiRulz added the App: EmuHawk Relating to EmuHawk frontend label Oct 18, 2025
Copy link
Contributor

@nattthebear nattthebear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could never follow the mainform shenanigans for frame advance event ordering and similar stuff very well.

This seems reasonable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

App: EmuHawk Relating to EmuHawk frontend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants