Fix video filename with ffmpeg writer #4512
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue fixed:
Result: The video is written to "test_1.mp4". File "test.mp4" was created but has no video.
This PR fixes the issue by pulling out the logic for acquiring a
IVideoProviderthat was being used inMainForm.AvFrameAdvanceto its own method, and using that method to obtain the initial video resolution.Check if completed: