-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix KCC schema link, comments #45
base: main
Are you sure you want to change the base?
Conversation
tomdaffurn
commented
Jul 26, 2024
- Fix link to KCC schema after directory move
- Clarify KCC schema is an example only, not a prescriptive part of the spec
- Correct VC Data Model to version 1.1
|
||
## Known Customer Credential Schema | ||
The json schema for the KCC can be found here: [KCC Schema](kcc-schema.json). This schema defines the structure and requirements for a Known Customer Credential, ensuring all necessary information is included and correctly formatted. | ||
A non-normative [example JSON schema](/schemas/kcc.schema.json) for a KCC is provided. PFIs may use any VC schema they desire, so long as they comply with the VC Data Model. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What am I misunderstanding here... isn't the whole point with the schema is that it's normative to a Known Customer Credential? It's not intending to be a JSON Schema for all VC Data Model instances, which is to say a normative schema for VC's, but it is intending to be normative for KCCs specifically.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I missed this. I agree @KendallWeihe, the schema should be normative.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The schema needs to be a part of the spec.
Curious why you think this @decentralgabe? The KCC spec can be used to issue any number of VCs, so making hard requirements about schema will limit what it can be used for. In previous comments (#22) you've suggested to generalise this spec and entirely decouple it from KCC. I see the KCC and KBC schema living here for a short time until a schema registry is available. |
Where are these VCs enumerated? I am fine with moving the schema, as long as we have a clear pointer to where the types of K** credentials are defined along with guidance on issuing and verifying these credentials.
I still think this is right, but I do not think we can make this change until #22 has taken effect.
A schema registry alone is insufficient. We still need a place to define the processing rules around the credentials. Like, what constitutes a valid KCC? How should it be verified? Who is able to issue one? How can it be interrogated for trustworthiness? Concretely, I believe we should do a few things
^^^ let's hash out the path forward there before removing the KCC schema |