Open
Conversation
rndnjsgud
reviewed
Mar 18, 2024
There was a problem hiding this comment.
입출력 시행도 클래스로 따로 분리하여 메인메소드를 실행한다면 조금 더 유지보수가 쉽고 코드가 간결해질 것 같습니다!
rndnjsgud
reviewed
Mar 18, 2024
There was a problem hiding this comment.
로또 결과를 종합하는 메소드와 결과를 출력하는 메소드를 나누면 메소드가 조금 더 짧아질 것 같습니다. 또, 결과를 return 할 수 있게 되어 else문을 안 쓸 수도 있을 것 같습니다. switch-case문도 안쓰는 방향으로 해보시면 좋을 것 같아요.
rndnjsgud
reviewed
Mar 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.