-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
메인화면 단순화 구현 #2
메인화면 단순화 구현 #2
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR올려주실때 View에 관련된 변동사항이 있으면, 영상이나 화면을 녹화 or 캡쳐하여서 업로드 부탁드려요 !
그리고 VIew를 분리하여 작성하는게 좋은데, 역시 밑에 참고한 레포에서 VIew 어떻게 작성하는지 참고하면 도움 많이 될겁니당.
@font-face { | ||
font-family: 'Pretendard'; | ||
font-weight: 900; | ||
font-display: swap; | ||
src: local('Pretendard Black'), url('./woff2/Pretendard-Black.woff2') format('woff2'), url('./woff/Pretendard-Black.woff') format('woff'); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
p5;
오 이거 처음보는데 설명가능할까요 ? 참고한 사이트가 있을까요 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
앗 이건 그냥 폰트 다운했을때 자동으로 생성된 파일입니다!
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
p3;
빈줄 있습니다.
struct DiaryList { | ||
var title: String | ||
var tag: [String] | ||
//var diaryimage : [Image] | ||
var day : Int | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
p3;
모델은 별도의 폴더로 관리해주셔도 좋습니다. Models 파일안에 DiaryList를 넣는 것도 좋아보여요.
네이밍 피드백인데, 우선 다이어리가 1개 인데 리스트라는 이름은 피했으면 합니다.
Diary 정도가 좋아보이네요.
//Views | ||
//에러 해결... | ||
struct DiaryListView: View { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
p3;
일단 정렬 해주세요. xcode 단축키가 있는데, 아마 cmd + a 로 전체 선택후, cmd + cnt + i 였나 그럴거에요
ZStack{ | ||
Image("background").ignoresSafeArea() | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
p3;
뒷 배경 때문이라면 다른 방식이 있어보입니다. 전체의 VStack의 Background 로 이미지를 채워넣는 방식을 고려해보세요.
.weight(.medium) | ||
) | ||
|
||
.kerning(0.288) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
p3;
kerning은 어떤 프로퍼티인지 간략하게 설명가능할까요.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
글자간 간격 조정입니다. 피그마에 고정값이 있길래 썼습니다!
ZStack(){ | ||
Button(action: {}) { | ||
Image("pencil") | ||
.frame(width: 42, height: 42) | ||
.padding(EdgeInsets(top: 700, leading: 170, bottom: 120, trailing: 170)) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
p5;
저는 이거 ZStack으로 사용하는 것은 인정합니다. 이런 경우에 ZStack을 사용하는 것이 맞다고 생각해요.
-앞으로 좀 더 할 것?
-p.s..
피그마에서 할당해준 패딩값으로 하니까 프리뷰에서는 자꾸 이상하게 나와서 일단 임의로 패딩값 잡았는데 그래도 될까? 양 옆 마진 정도는 같게 만들었오