Feat/#17 SignUp,UserInfo TCA 적용 #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mooyoung2309
approved these changes
Oct 9, 2023
Comment on lines
+16
to
+18
| init() { | ||
| Thread.sleep(forTimeInterval: 2) | ||
| } |
There was a problem hiding this comment.
이건 스플래시 화면을 만들었는데 빌드하니까 너무 빨리 사라져서, 스플래시 화면을 더 길게 보기위해서 임시로 작성한 코드입니다!
| @@ -12,15 +12,90 @@ import ComposableArchitecture | |||
|
|
|||
| public struct OnboardingUserInfoView: View { | |||
| let store: StoreOf<OnboardingUserInfoStore> | |||
| @State private var name = "" | |||
| @State private var showingAlert: Bool = false | |||
There was a problem hiding this comment.
p5;
alert도 TCA가 적용되면 좋을것같아요! 패스 해도 가능.
튜토리얼에 alert 예제까지 있는걸로 알아요!
There was a problem hiding this comment.
alert를 찾아보니까 난이도가 어려워보여서, 다른 일 먼저 하고 alert도 TCA 적용시켜보겠습니다!
Comment on lines
21
to
+28
| WithViewStore(self.store, observe: { $0 }) { viewStore in | ||
| VStack { | ||
| Text("Onboarding User Info View") | ||
| VStack{ | ||
| Spacer() | ||
| HStack(){ | ||
| Text("마지막으로,") | ||
| .font(.bold16) | ||
| .foregroundColor(.black) | ||
| Spacer() |
There was a problem hiding this comment.
p4;
전체적으로 View가 너무 길어져요. 함수로 빼거나, 파일로 분리하는 방식으로 가독성을 높이면 좋을 것 같습니다.
There was a problem hiding this comment.
넵 함수로 빼서 고치겠습니다!
| @@ -12,16 +12,15 @@ struct TermsView: View { | |||
| var body: some View { | |||
| NavigationView(){ | |||
| VStack{ | |||
| Image("vector") | |||
| PldaAsset.Images.vector9.swiftUIImage | |||
There was a problem hiding this comment.
p5;
너무 이름이 길어지는 것 같은데, 뭔가 좋은방법이 없을까요? 한번 고민해보면 좋을 것 같아요.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 요약
온보딩 중 SignUpView와 UerInfoView에 TCA를 적용시켰습니다.
📌 변경 사항
이미지 파일을 tuist 접근으로 쓸 수 있게 바꾸었습니다.
✅ PR check list
아무런 정보를 기입하지 않았을때 다음 화면으로 가는 것을 막아두었습니다.
그때마다 alert를 띄우고 싶어서 코드를 써보았는데, TCA적용을 하면 자꾸 오류가 나서 일단 showingAlert 부분은 TCA 적용을 하지 않은 상태입니다.
Linked Issue
close #17
Preview
SignUpView
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2023-10-09.at.15.31.24.mp4
UserInfoView
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2023-10-09.at.15.32.43.mp4