Add region probe infrastructure #159
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The region probes are divided in three levels: - User probes: defined by the user using ttg::user_probe; compile with -DTTG_ENABLE_USER_PROBES=1 to enable. - Task probes: task execution instrumentation using names provided to ttg::Op; compile with -DTTG_ENABLE_TASK_PROBES=1 to enable. - Internal probes: all the gory runtime-internal details; compile with -DTTG_ENABLE_INTERNAL_PROBES=1 to enable. At the moment, the latter two are only available in the PaRSEC backend. User probes can be defined any time and work with any backend that uses PaRSEC. To enable tracing in PaRSEC, users have to export the following two environment variables: - PARSEC_MCA_mca_pins=task_profiler - PARSEC_MCA_profile_filename=<filename> (files must not exist) Signed-off-by: Joseph Schuchart <[email protected]>
devreal
force-pushed
the
ttg_region_probe
branch
from
5e7602b to
daf9994
Compare
An example use case is the size of an active message sent. Signed-off-by: Joseph Schuchart <[email protected]>
Signed-off-by: Joseph Schuchart <[email protected]>
evaleev
reviewed
Sep 17, 2021
| #include <vector> | ||
| #include <cassert> | ||
|
|
||
| #include <parsec/profiling.h> |
Contributor
There was a problem hiding this comment.
should this be protected by ifdefs to avoid having to introduce dependence of ttg target on parsec targets. Alternatively we can make parsec a hard dependence of TTG, but that may be undesirable long term.
Contributor
Author
There was a problem hiding this comment.
I don't think we have a HAVE_PARSEC preprocessor flag right now and both the madness and parsec backends provide access to the parsec header/libs. If we create a backend that does not depend on PaRSEC we'll have to revisit that.
Contributor
|
There are three things in this PR:
We may want to split this PR in parts, and integrate part 2 and 3. Part 1 (new framework) could be provided by PINS in PaRSEC; or the new framework is simpler. We have not decided on that yet. |
evaleev
force-pushed
the
master
branch
4 times, most recently
from
a2878ce to
a49eb91
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The region probes are divided into three levels:
At the moment, the latter two are only available in the PaRSEC backend.
User probes can be defined any time and work with any backend that uses PaRSEC.
To enable tracing in PaRSEC, users have to export the following two
environment variables:
Note that in the wake of the instrumentation, I also encapsulated some code snippets to avoid (and reducing existing) code duplication.
Signed-off-by: Joseph Schuchart [email protected]