PaRSEC TTG: Offload stream reductions #256
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@therault the tests are failing because the madness tag is unavailable. Do you have a tag to use instead? |
Contributor
|
31b2470ca722a6a2d84d4de08d32fb72ae8fdeda
therault/madness@31b2470
…On Fri, May 26, 2023 at 2:45 PM Joseph Schuchart ***@***.***> wrote:
@therault <https://github.com/therault> the tests are failing because the
madness tag is unavailable. Do you have a tag to use instead?
—
Reply to this email directly, view it on GitHub
<#256 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABFEZNSFGJ2BHTDXHUSORLDXID223ANCNFSM6AAAAAAYQR7TLA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
devreal
force-pushed
the
offload-stream-reductions
branch
from
7bd063b to
ab86822
Compare
devreal
force-pushed
the
offload-stream-reductions
branch
2 times, most recently
from
e34d232 to
35a1002
Compare
This is needed to work-around missing support for offsetof in virtual classes. Instead we store the pointer to the derived class inside the non-virtual base class. This allows us to store data copies in parsec lifo or lists and get the virtual derived object back. Signed-off-by: Joseph Schuchart <schuchart@icl.utk.edu>
Signed-off-by: Joseph Schuchart <schuchart@icl.utk.edu>
When we encounter a streaming terminal we schedule a dedicated reducer task. Subsequent inputs are put into a LIFO. Once the reducer task runs it will process all available inputs for that terminal but will not block waiting for all inputs. In the worst case, we create N tasks (one for each input), likely less. Signed-off-by: Joseph Schuchart <schuchart@icl.utk.edu>
The thread-local variable was a hack that is not needed anymore, and apparently didn't work properly. Signed-off-by: Joseph Schuchart <schuchart@icl.utk.edu>
Signed-off-by: Joseph Schuchart <schuchart@icl.utk.edu>
Signed-off-by: Joseph Schuchart <schuchart@icl.utk.edu>
Signed-off-by: Joseph Schuchart <schuchart@icl.utk.edu>
Signed-off-by: Joseph Schuchart <schuchart@icl.utk.edu>
…puts In the PaRSEC backend, reducer tasks will be treated as any other task and be deferred if there are readers on their first input. All other inputs are read-only and will be handled that way. This avoids extra copies if there are no other writers on these copies. Signed-off-by: Joseph Schuchart <schuchart@icl.utk.edu>
Signed-off-by: Joseph Schuchart <schuchart@icl.utk.edu>
devreal
force-pushed
the
offload-stream-reductions
branch
from
dd5c0e7 to
68a9852
Compare
evaleev
force-pushed
the
master
branch
4 times, most recently
from
a2878ce to
a49eb91
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we encounter a streaming terminal we schedule a dedicated
reducer task. Subsequent inputs are put into a LIFO. Once the
reducer task runs it will process all available inputs for that
terminal but will not block waiting for all inputs. In the
worst case, we create N tasks (one for each input), likely less.
Currently we use the priority of the task we stream into but this should be revisited, maybe a higher priority could be useful.