Skip to content

Fix handling of invalid buffer scopes #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
devreal wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix handling of invalid buffer scopes #319

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ttg/ttg/parsec/buffer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -459,7 +459,7 @@ struct Buffer {
void reset_scope(ttg::scope scope) {
if (scope == ttg::scope::Allocate) {
m_data->device_copies[0]->version = 0;
} else {
} else if (scope == ttg::scope::Invalid) {
m_data->device_copies[0]->version = 1;
/* reset all other copies to force a sync-in */
for (int i = 0; i < parsec_nb_devices; ++i) {
Expand All @@ -473,7 +473,7 @@ struct Buffer {

ttg::scope scope() const {
/* if the host owns the data and has a version of zero we only have to allocate data */
if (nullptr != m_data) return ttg::scope::Invalid;
if (nullptr == m_data) return ttg::scope::Invalid;
return (m_data->device_copies[0]->version == 0 && m_data->owner_device == 0)
? ttg::scope::Allocate : ttg::scope::SyncIn;
}
Expand Down
Loading