Skip to content

fix: auto-select usable provider when local model is stale #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nkmohit wants to merge 3 commits into
base: main
Choose a base branch
from
+14 −3
Open

fix: auto-select usable provider when local model is stale #126

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9641cfa
fix: auto-select usable provider when local model is stale
nkmohit Mar 19, 2026
0340672
Merge branch 'main' into fix/llm-autoselect-unusable-provider
nkmohit Mar 21, 2026
690676a
Merge branch 'main' into fix/llm-autoselect-unusable-provider
nkmohit Mar 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions lib/store/settings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -894,6 +894,14 @@ export const useSettingsStore = create<SettingsState>()(
}
}

const isProviderUsable = (
config: (typeof newProvidersConfig)[ProviderId] | undefined,
) =>
!!config &&
(!config.requiresApiKey || !!config.apiKey || !!config.isServerConfigured) &&
config.models.length >= 1 &&
!!(config.baseUrl || config.defaultBaseUrl || config.serverBaseUrl);

// === Auto-select / auto-enable (only on first run) ===
let autoTtsProvider: TTSProviderId | undefined;
let autoTtsVoice: string | undefined;
Expand Down Expand Up @@ -960,12 +968,15 @@ export const useSettingsStore = create<SettingsState>()(
}
}

// LLM auto-select: when modelId is empty
let autoProviderId: ProviderId | undefined;
let autoModelId: string | undefined;
if (!state.modelId) {
const currentProviderConfig = newProvidersConfig[state.providerId];
const shouldAutoSelectLLM =
!state.modelId || !isProviderUsable(currentProviderConfig);

if (shouldAutoSelectLLM) {
for (const [pid, cfg] of Object.entries(newProvidersConfig)) {
if (cfg.isServerConfigured) {
if (cfg.isServerConfigured && isProviderUsable(cfg)) {
// Prefer server-restricted models, fall back to built-in list
const serverModels = cfg.serverModels;
const modelId = serverModels?.length
Expand Down
Loading