Skip to content

fix: use aread() to fully consume HTTP response body #1488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ann-qin-lu wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: use aread() to fully consume HTTP response body #1488

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
28d5def
fix: use aread() to fully consume HTTP response body
ann-qin-lu Jan 24, 2026
173c272
Merge branch 'main' into fix/httpx-close-wait
ann-qin-lu Jan 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions slime/utils/http_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,10 +168,11 @@ async def _post(client, url, payload, max_retries=60):
try:
response = await client.post(url, json=payload or {})
response.raise_for_status()
content = await response.aread()
try:
output = response.json()
output = json.loads(content)
except json.JSONDecodeError:
output = response.text
output = content.decode() if isinstance(content, bytes) else content
except Exception as e:
retry_count += 1

Expand Down Expand Up @@ -286,5 +287,6 @@ async def post(url, payload, max_retries=60):
async def get(url):
response = await _http_client.get(url)
response.raise_for_status()
output = response.json()
content = await response.aread()
output = json.loads(content)
return output