Raise error if credentials are invalid (fix #110)

DESCRIPTION

@@ -1,7 +1,7 @@
 Package: BacDiveR
 Title: Programmatic Interface For The Bacterial Diversity
     Metadatabase by DSMZ
-Version: 0.9.0
+Version: 0.9.1
 Authors@R: 
     person(given = "Katrin",
            family = "Leinweber",

NEWS.md

@@ -7,6 +7,13 @@
 ### Fixed
 ### Security
 
+
+## BacDiveR 0.9.1
+
+### Fixed
+
+- Expose a previously silent download error (#110; Thanks to @jfy133!)
+
 ## BacDiveR 0.9.0
 
 All notable changes to this project will be documented in this file.

R/util-download.R

@@ -12,5 +12,11 @@ download <- function(URL, user = get_credentials()[1], password = get_credential
 
   response <- httr::GET(URL, httr::authenticate(user, password))
   payload <- httr::content(response, as = "text", encoding = "UTF-8")
-  jsonlite::fromJSON(payload)
+  data <- jsonlite::fromJSON(payload)
+
+  if (response$status_code == 403) {
+    stop(paste(data, "\nCheck your .Renviron file, and try copy-pasting your login credentials into https://bacdive.dsmz.de/api/bacdive/ to test them. Correct as necessary and try your data download again."))
+  } else {
+    return(data)
+  }
 }

tests/testthat/test-download.R

@@ -0,0 +1,4 @@
+test_that("Downloading without preper credentials raises an error", {
+  random <- sample(letters, 8)
+  expect_error(download(construct_url(717), user = random, password = random))
+})