Skip to content

Restore local table-schema.json#165

Merged
SorenSpicknall merged 2 commits intomainfrom
soren-restore_local_spec_copy
Oct 4, 2023
Merged

Restore local table-schema.json#165
SorenSpicknall merged 2 commits intomainfrom
soren-restore_local_spec_copy

Conversation

@SorenSpicknall
Copy link
Copy Markdown
Contributor

Pull Request

In #149, we implemented a very slightly modified local copy of the standard table-schema.json file to support the draft-07 JSON schema spec after testing various validation actions and finding a somewhat inelegant solution that allowed us to continue to validate what we wanted. This file was inadvertently judged as inessential in #162 and deleted, and the deletion is now causing failures of this GitHub action that relied on the file.

This PR restores the deleted file to the repo.

@SorenSpicknall SorenSpicknall requested a review from e-lo October 3, 2023 19:29
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 3, 2023

Documentation available at: http://tides-transit.github.io/TIDES/soren-restore_local_spec_copy

Copy link
Copy Markdown
Contributor

@e-lo e-lo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but can you add an issue that would tidy this all up at some point ?

@SorenSpicknall SorenSpicknall merged commit cbb79c7 into main Oct 4, 2023
@SorenSpicknall
Copy link
Copy Markdown
Contributor Author

LGTM but can you add an issue that would tidy this all up at some point ?

Will do!

@SorenSpicknall SorenSpicknall deleted the soren-restore_local_spec_copy branch October 4, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants