Skip to content

Change requirement for cleaning to be from TIDES repo.#215

Merged
e-lo merged 1 commit intomainfrom
fix-ci-delete-branch
Jan 18, 2024
Merged

Change requirement for cleaning to be from TIDES repo.#215
e-lo merged 1 commit intomainfrom
fix-ci-delete-branch

Conversation

@e-lo
Copy link
Copy Markdown
Contributor

@e-lo e-lo commented Jan 18, 2024

Previous requirement didn't work and nothing was cleaned.

Fixes #210

@e-lo e-lo added the 🐛 bug Something isn't working – in spec or code label Jan 18, 2024
@e-lo e-lo requested a review from SorenSpicknall January 18, 2024 00:44
@e-lo e-lo self-assigned this Jan 18, 2024
@github-actions
Copy link
Copy Markdown
Contributor

Documentation available at: http://tides-transit.github.io/TIDES/fix-ci-delete-branch

Copy link
Copy Markdown
Contributor

@SorenSpicknall SorenSpicknall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't test this easily without recreating the whole docs publication flow elsewhere, so for convenience's sake (since the workflow is already not doing what it's supposed to) I'm supportive of merging this and then testing with a couple of sample deletions in prod. If the new criteria doesn't pick up our intended deletion prompt, we won't be any worse off than we are now. Approved!

@e-lo e-lo marked this pull request as ready for review January 18, 2024 17:56
@e-lo e-lo requested a review from a team as a code owner January 18, 2024 17:56
@e-lo e-lo merged commit 1f3c451 into main Jan 18, 2024
@e-lo e-lo deleted the fix-ci-delete-branch branch January 18, 2024 17:57
@e-lo
Copy link
Copy Markdown
Contributor Author

e-lo commented Jan 18, 2024

Well...success on it running the action - not success on it working. @SorenSpicknall that looks scary...it was trying to delete main !?

image

@SorenSpicknall
Copy link
Copy Markdown
Contributor

There's a couple of things happening here. No risk to the branches themselves, but the specific pathway for a branch deletion was based on the context of the Action run after it was triggered by a deletion event. This meant that the head_ref at that time was main instead of the name of the deleted branch.

In #216, I changed the ref to use the branch from the deletion event itself, rather than the state of the repo after the deletion. The warnings about branch/repo state may just have to do with the attempt to operate on the main branch, but we'll see - we might need to do a little bit of cleanup of the automated gh-pages branch to get things fully operational after #216 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛 bug Something isn't working – in spec or code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 CI not deleting refs in mike when refs to branches deleted

2 participants