Change requirement for cleaning to be from TIDES repo.#215
Conversation
|
Documentation available at: |
SorenSpicknall
left a comment
There was a problem hiding this comment.
We can't test this easily without recreating the whole docs publication flow elsewhere, so for convenience's sake (since the workflow is already not doing what it's supposed to) I'm supportive of merging this and then testing with a couple of sample deletions in prod. If the new criteria doesn't pick up our intended deletion prompt, we won't be any worse off than we are now. Approved!
|
Well...success on it running the action - not success on it working. @SorenSpicknall that looks scary...it was trying to delete
|
|
There's a couple of things happening here. No risk to the branches themselves, but the specific pathway for a branch deletion was based on the context of the Action run after it was triggered by a deletion event. This meant that the In #216, I changed the ref to use the branch from the deletion event itself, rather than the state of the repo after the deletion. The warnings about branch/repo state may just have to do with the attempt to operate on the |

Previous requirement didn't work and nothing was cleaned.
Fixes #210