Rename duration fields with explicit suffix#249
Open
chrisyamas wants to merge 3 commits intodevelopfrom
Open
Conversation
Contributor
|
Documentation available at: |
Contributor
|
Also modify samples/template/TIDES/stop_visits.csv |
Contributor
|
Data Validation Report
|
Contributor
Author
@jlstpaul, I updated samples/template/TIDES/stop_visits.csv to rename |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a breaking change as it renames three duration fields in
stop_visitsfrom*_timeto*_durationsuffix to clearly distinguish them from timestamp fields likeactual_arrival_time.Resolves #237
Changes
spec/stop_visits.schema.jsonrenamed fields:ramp_deployed_time-->ramp_deployed_durationkneel_deployed_time-->kneel_deployed_durationlift_deployed_time-->lift_deployed_durationCHANGELOG.mdadded BREAKING change entry under[Unreleased]Reason for this change
The
_timesuffix creates confusion because the same table uses_timefor actual timestamps (e.g.,actual_arrival_time,schedule_departure_time). Users shouldn't have to read the description to know whether a field contains a point-in-time or a duration.\The new
_durationsuffix makes the field type immediately clear (and aligns with common naming conventions where_timeindicates timestamps and_durationindicates elapsed time).- See related discussion in Issue #237 and Fall 2025 TIDES Issues Working Group notes from December 10.
Review checklist
Per TIDES change management policy, the following must be met before feature branch changes can merge to
developbranch: