Skip to content

fix(cli): Handle qualified ranges in eval sheet inference (GH-210) #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arcaputo3 merged 1 commit into from
Feb 8, 2026
Merged

fix(cli): Handle qualified ranges in eval sheet inference (GH-210) #217

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion xl-cli/src/com/tjclp/xl/cli/commands/ReadCommands.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,7 +448,9 @@ object ReadCommands:
)
)
else
val sheet = sheetOpt.getOrElse(wb.sheets.head)
// Safe: wb.sheets.isEmpty is checked above, so headOption is always Some
val sheet = (sheetOpt.orElse(wb.sheets.headOption): @unchecked) match
case Some(s) => s
for
tempSheet <- applyOverrides(sheet, overrides)

Expand Down
5 changes: 4 additions & 1 deletion xl-evaluator/src/com/tjclp/xl/formula/graph/DependencyGraph.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,10 @@ object DependencyGraph:
.toValues(call.args)
.exists {
case ArgValue.Expr(e) => containsUnqualifiedCellReferences(e)
case ArgValue.Range(_) => true
case ArgValue.Range(loc) =>
loc match
case TExpr.RangeLocation.Local(_) => true
case TExpr.RangeLocation.CrossSheet(_, _) => false
case ArgValue.Cells(_) => true
}

Expand Down