Skip to content

Add Armor King and Miary Zo#26

Open
suprovsky wants to merge 19 commits into
TLNBS2405:masterfrom
suprovsky:master
Open

Add Armor King and Miary Zo#26
suprovsky wants to merge 19 commits into
TLNBS2405:masterfrom
suprovsky:master

Conversation

@suprovsky
Copy link
Copy Markdown

@suprovsky suprovsky commented Oct 14, 2025

if u want i can add a pipeline building the container automatically on push

@TLNBS2405
Copy link
Copy Markdown
Owner

Can you do a pre commit check for the test to be green?

@suprovsky
Copy link
Copy Markdown
Author

i've also added:

  • github ci pipelines for building, scanning and checking Dockerfile quality (you must add a secret called GHCR_TOKEN to the repo, otherwise pushing the image to github will fail, also after you do that you have to make the image public, so it's possible to download it for others
  • distroless container uses python 3.11, so i updated python-app.yml, so it has up to date versions of modules, made it use python 3.11 (it works, i'm running the bot on my own server now)
  • updated pre-commit-config, so there is no deprecation warning of a stage name being run

if u want to talk quicker on chat or have quick questions, i joined wavu discord as suprovsky, so feel free to dm me

@AbhijeetKrishnan
Copy link
Copy Markdown
Contributor

Could you split this into two PRs? One to add Armor King, and the other to dockerize the app. I'm also not sure what benefit we'd get from the latter.

@suprovsky
Copy link
Copy Markdown
Author

sure will do, having app containerized lets you host an app in a container system like Docker or Kubernetes and that gives a lot of advantages compared to standard hosting, you should have a look at these in the Internet to know more, but for me the biggest selling point is separation between apps and not dealing with multiple versions of the same binaries/libraries on a host

@suprovsky suprovsky changed the title Add Armor King commands and Dockerize the app Add Armor King and Miary Zo Jan 9, 2026
@suprovsky
Copy link
Copy Markdown
Author

suprovsky commented Jan 9, 2026

updated, i've added Miary Zo, because it makes sense to have two the same type of features in one pull request
when merging, please just squash it, so it doesn't contain trash from my commits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants