Merged
Conversation
jchate6
approved these changes
Jan 23, 2026
Contributor
jchate6
left a comment
jchate6
left a comment
There was a problem hiding this comment.
Thanks for the PR!
This code is not really hit anywhere in the base TOM.
Out of curiosity when does this become an issue for you? Do you have a custom search bar that uses this view?
Contributor
Author
Yes we added a search bar to the main page and the navbar, similar to SNEx, to do a fuzzy search by name. Thanks for the quick approval! |
github-project-automation
bot
moved this from Needs Review
to Merged (to dev)
in TOM Toolkit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For large target tables, the search by name is currently very slow. The query can be sped up by separating the name and alias queries and avoiding sorting the giant table, by replacing
.distinct()and.first()with.union()and.get(). With ~11 million targets, this brings the time down from ~55 seconds to ~5 seconds. I also added a.strip()to remove leading or trailing whitespace (sometimes this gets easily pasted in).I'm not sure if the comment in the middle of this function is still relevant, but feel free to delete it if not.