Add cmake workaround for hdf5 version detection when using hdf5 with subversion #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmenke
reviewed
Jul 23, 2024
Wentzell
force-pushed
the
DEV_H5SUBV_ISSUE
branch
from
0be0e93 to
9b0c67d
Compare
|
Thank you @hmenke for the suggestions, I have updated the PR accordingly. |
|
Note that the |
hmenke
reviewed
Jul 25, 2024
c++/h5/CMakeLists.txt
Outdated
| endif() | ||
| if(HDF5_VERSION VERSION_GREATER_EQUAL 1.13) | ||
| target_compile_definitions(h5_c PRIVATE H5_USE_110_API) | ||
| if(NOT HDF5_VERSION VERSION_LESS 1.13) |
There was a problem hiding this comment.
I was too optimistic. This doesn't work when HDF5_VERSION is missing altogether.
|
Ok. Can I ask which hdf5 versions are affected by this issue? |
|
This started with 1.14.1. Before that the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.