fix: prevent double-plant half duplication - #95
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
halfproperty for multi-blockBisectedblock data by defaulthalfediting for stairs and trapdoorsBlockDataFilter.AllowUnsafeBisectedDatafor servers that intentionally need the original behaviorRoot cause
DebugStickPro applies block data to only the targeted block with physics disabled. Changing a double plant from its upper half to a lower half can therefore leave two independent lower halves, each of which produces a drop when broken.
The existing configurable blacklist can mitigate this only when explicitly enabled. The shared separation point now protects classic and copy modes by default. Administrators can set
BlockDataFilter.AllowUnsafeBisectedData: trueto restore multi-blockBisectedediting when that risk is acceptable. Stairs and trapdoors remain available because theirhalfproperty is a valid single-block placement property.Adding the setting increments the config version to 8, following the project's existing config migration behavior.
Verification
mvn -B test(4 tests, 0 failures)mvn -B packageFixes #37