fix: support Paper 1.19.4 and skip degenerate render lines - #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
api-versionto 1.19 so Paper 1.19.4 can load the pluginContext
The 2.4.0 compatibility matrix found three failures:
api-versionwas 1.20.IllegalArgumentException: line endpoints must be distinctand partial renders.The common
renderLineboundary now uses the same squared-length threshold (1e-6) as TextDisplayShapes, which also protects other renderers from invalid generated geometry.Verification
mvn clean package: 34 tests passedtext_displayspawn packetsPaper versions tested: 1.19.4; 1.20, 1.20.1, 1.20.2, 1.20.4, 1.20.5, 1.20.6; 1.21, 1.21.1, 1.21.3, 1.21.4, 1.21.5, 1.21.6, 1.21.7, 1.21.8, 1.21.9, 1.21.10, 1.21.11; 26.1.1, 26.1.2, 26.2. The 26.2 client packet check used a 26.1.2 Mineflayer client through ViaVersion/ViaBackwards because
minecraft-datadoes not yet ship a 26.2 registry; the Paper 26.2 server and WED execution were native.