fix: drop Nitro from public React Start examples - #1414
Conversation
|
View your CI Pipeline Execution ↗ for commit 8e20557
☁️ Nx Cloud last updated this comment at |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (9)
📝 WalkthroughWalkthroughThe change removes Nitro dependencies and Vite plugin configuration from three React examples and the React app generator template. Generator tests now verify that generated projects do not include Nitro references. ChangesNitro integration removal
Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The website sandbox fails with
Vite environment "nitro" is unavailable. Working Start docs sandboxes do not use Nitro.start-counterandstart-streaming-data-from-server-functionsruntanstackStart()andviteReact()only. Nitro is optional hosting, not required forvite devor API routes.This PR removes Nitro from Basic Chat, Generate Image, Streaming Structured Table, and the Nx React app template.
🎯 Changes
Public React tutorial apps now match the working Start examples.
tanstackStart()serves/api/chat.No docs page change. Tutorials never named Nitro. No changeset.
✅ Checklist
pnpm run test:pr, or these tests do not apply to this pull request.docs/for this change, or this change is not user-facing.pnpm changeset), or this PR does not change a published package.🚀 Release Impact
Testing
Commands run:
vitest run tools/workspace-plugin/src/generators/react-app/generator.spec.tspassed.pnpm --filter basic-chat test:typespassed.viteon Basic Chat without Nitro:GET /returned 200.POST /api/chatreturned 400Invalid AG-UI request body(the API route ran). Nonitro is unavailableerror.pnpm run test:prwas not run.Manual test after this merges and the site fetches
main:Vite environment "nitro" is unavailableerror.Risk / rollback
Local and sandbox Start now use the Vite plugin only. Revert this PR to put Nitro back.
Summary by CodeRabbit