- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 536
feat(solid-form): add withFieldGroup API #1783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| π¦ Changeset detectedLatest commit: 71b7a35 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
 Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR | 
| View your CI Pipeline Execution β for commit 71b7a35 
 βοΈ Nx Cloud last updated this comment at  | 
| Codecov Reportβ
 All modified and coverable lines are covered by tests. Additional details and impacted files@@            Coverage Diff             @@
##             main    #1783      +/-   ##
==========================================
+ Coverage   90.35%   95.23%   +4.88%     
==========================================
  Files          38        4      -34     
  Lines        1752      105    -1647     
  Branches      444        7     -437     
==========================================
- Hits         1583      100    -1483     
+ Misses        149        5     -144     
+ Partials       20        0      -20     β View full report in Codecov by Sentry. π New features to boost your workflow:
 | 
| Looking good! There's one thing that I'm curious about: #1648 lists a problem with React's implementation of  | 
| Most likely, but will try to reproduce and let you know | 
| @LeCarbonator  , I have tested it , first I would thought that, the implementation is same so there is a change , but to my suprise, the bug is not presented in the solid version, then later only realized that solids signal based reactive pattern does not dependent on component state to rerender the component, and state are independent. so case in point , this #1648 issues from react version of  | 
| Wow nice, can't wait for this feature anymore | 
| @Vijayabaskar56 Sounds good, then! I guess this PR is not blocked by that then. We'll try to review it soon. | 
| looking forward to it.. π. | 
π― Changes
Add the
withFieldGroupAPI for Form Composition in Solid Formβ Checklist
pnpm test:pr.π Release Impact