Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe PR updates ChangesQueryClient tooling alignment
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~12 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The changes align ESLint and type-test coverage with current QueryClient methods, with no unresolved production risk identified. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
c5d6919 to
62ebee2
Compare
| 'ensureQueryData', | ||
| 'ensureInfiniteQueryData', | ||
| ] | ||
| const queryClientOptionMethods = ['query', 'infiniteQuery'] |
There was a problem hiding this comment.
I would just widen the list, queryOptions are still preferred even for the deprecated options. Deleting the tests is fine
- Update prefer-query-options for `query` and `infiniteQuery` - Refresh infinite-query type tests and lint rule coverage
9e6a651 to
9827188
Compare
🎯 Changes
queryandinfiniteQuery✅ Checklist
pnpm run test:pr, or these tests do not apply to this pull request.🚀 Release Impact
Summary by CodeRabbit
New Features
prefer-query-optionsESLint rule now recognizesqueryClient.queryandqueryClient.infiniteQuerycalls and flags inline query options appropriately.Tests