Angular persist query client experimental #8324
Open
+2,256
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OmerGronich
force-pushed
the
angular-persist-query-client-experimental
branch
from
8474149 to
31c8c0e
Compare
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 5d80309. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution
✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
OmerGronich
force-pushed
the
angular-persist-query-client-experimental
branch
3 times, most recently
from
0ff5f5c to
b4d880a
Compare
OmerGronich
force-pushed
the
angular-persist-query-client-experimental
branch
from
566f72a to
e1ae58d
Compare
OmerGronich
force-pushed
the
angular-persist-query-client-experimental
branch
2 times, most recently
from
d4fa95c to
9e4182a
Compare
arnoud-dv
requested changes
Dec 1, 2024
examples/angular/basic-persister/.devcontainer/devcontainer.json
Outdated
Show resolved
Hide resolved
OmerGronich
force-pushed
the
angular-persist-query-client-experimental
branch
3 times, most recently
from
3c3c8ec to
ed0ed3c
Compare
- Created isRestoring injection token and provider - handled restoration phase in create-base-query.ts - handled restoration phase in
…port, and the withPersistQueryClient feature
Co-authored-by: Arnoud <[email protected]>
Co-authored-by: Arnoud <[email protected]>
Co-authored-by: Arnoud <[email protected]>
Co-authored-by: Arnoud <[email protected]>
Co-authored-by: Arnoud <[email protected]>
Co-authored-by: Arnoud <[email protected]>
Co-authored-by: Arnoud <[email protected]>
…tes how to selectively persist queries to different persisters.
OmerGronich
force-pushed
the
angular-persist-query-client-experimental
branch
from
ed0ed3c to
325b2a7
Compare
…ry-client-experimental # Conflicts: # packages/angular-query-experimental/src/create-base-query.ts
…ry-client-experimental
…e React adapter logic
…match the React adapter logic" This reverts commit 235bbab.
# Conflicts: # pnpm-lock.yaml
crutchcorn
reviewed
Mar 10, 2025
OmerGronich
commented
Mar 12, 2025
| @@ -104,33 +106,33 @@ export function createBaseQuery< | |||
| }, | |||
| ) | |||
|
|
|||
| effect(() => { | |||
| effect((onCleanup) => { | |||
There was a problem hiding this comment.
I was requested to review this PR from OP - it generally looks good to me! Seems like a lot of edgecases handled as well.
Anything you want to me to take a closer eye on?
@crutchcorn Yes, one thing I wanted an opinion on is this cleanup that I added here, does it make sense to you? Do we need to do the same in the injectQueries function?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Angular Query Persister Plugin
angular-query-persist-client-packagewithPersistQueryClientin new package