Skip to content

fix(query-devtools): move solid to deps #8990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(query-devtools): move solid to deps #8990

wants to merge 2 commits into from

Conversation

birkskyum
Copy link
Member

move solid (which the agnostic devtools are built with) to deps, like it is in the router devtools:

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Apr 10, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit bd4ee2a.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ❌ Failed 3m 2s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 2m 5s View ↗

☁️ Nx Cloud last updated this comment at 2025-04-17 09:16:35 UTC

@birkskyum birkskyum force-pushed the fix(query-devtools)--resolve-solid-js-as-dep branch from 9d665ad to 76d656e Compare April 10, 2025 17:56
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Apr 10, 2025 •
edited
Loading

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@8990

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@8990

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@8990

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@8990

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@8990

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@8990

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@8990

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@8990

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@8990

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@8990

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@8990

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@8990

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@8990

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@8990

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@8990

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@8990

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@8990

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@8990

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@8990

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@8990

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@8990

commit: bd4ee2a

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 10, 2025 •
edited
Loading

Sizes for commit bd4ee2a:

Branch Bundle Size
Main
This PR

@TkDodo
Copy link
Collaborator

TkDodo commented Apr 17, 2025

does that mean if you use the react-query-devtools, you have a runtime dependency on solid ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
package: query-devtools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@birkskyum @TkDodo