Skip to content

refactor(angular-query): improve devtools tree shaking #9022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

refactor(angular-query): improve devtools tree shaking #9022

wants to merge 5 commits into from

Conversation

arnoud-dv
Copy link
Collaborator

@arnoud-dv arnoud-dv commented Apr 15, 2025 •
edited
Loading

Improves tree shaking to about 0,13KB

Adds deps option - fixes #8824

@github-actions github-actions bot added documentation Improvements or additions to documentation package: angular-query-experimental labels Apr 15, 2025
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Apr 15, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 8ee4ba7.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 4m 15s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 11s View ↗

☁️ Nx Cloud last updated this comment at 2025-04-25 15:13:21 UTC

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Apr 15, 2025 •
edited
Loading

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@9022

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@9022

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@9022

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@9022

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@9022

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@9022

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@9022

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@9022

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@9022

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@9022

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@9022

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@9022

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@9022

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@9022

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@9022

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@9022

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@9022

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@9022

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@9022

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@9022

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@9022

commit: 8ee4ba7

@codecov Codecov
Copy link

codecov bot commented Apr 15, 2025

Codecov Report

Attention: Patch coverage is 98.30508% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.54%. Comparing base (4a5990e) to head (95409df).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #9022       +/-   ##
===========================================
+ Coverage   44.58%   86.54%   +41.96%     
===========================================
  Files         203       18      -185     
  Lines        8106      327     -7779     
  Branches     1801       71     -1730     
===========================================
- Hits         3614      283     -3331     
+ Misses       4060       39     -4021     
+ Partials      432        5      -427
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental 85.66% <98.27%> (+0.43%) ⬆️
@tanstack/eslint-plugin-query ∅ <ø> (∅)
@tanstack/query-async-storage-persister ∅ <ø> (∅)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods ∅ <ø> (∅)
@tanstack/query-core ∅ <ø> (∅)
@tanstack/query-devtools ∅ <ø> (∅)
@tanstack/query-persist-client-core ∅ <ø> (∅)
@tanstack/query-sync-storage-persister ∅ <ø> (∅)
@tanstack/react-query ∅ <ø> (∅)
@tanstack/react-query-devtools ∅ <ø> (∅)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client ∅ <ø> (∅)
@tanstack/solid-query ∅ <ø> (∅)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client ∅ <ø> (∅)
@tanstack/svelte-query ∅ <ø> (∅)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client ∅ <ø> (∅)
@tanstack/vue-query ∅ <ø> (∅)
@tanstack/vue-query-devtools ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation package: angular-query-experimental
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Angular: withDevtools option loadDevtools no longer supports dependency injection
1 participant
@arnoud-dv