Skip to content

test(react-query): initialise queryClient in beforeEach #9142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 12, 2025
Merged

test(react-query): initialise queryClient in beforeEach #9142

merged 1 commit into from
May 12, 2025

Conversation

lachlancollins
Copy link
Member

@lachlancollins lachlancollins commented May 12, 2025 •
edited
Loading

When porting useMutation tests to svelte-query, I noticed that the beforeEach function for useMutation did not re-initialise the mutationCache. This doesn't seem to have caused any bugs, but should be fixed. The other package tests use a slightly different initialisation format which is less prone to this issue, so I've tidied it up a little.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented May 12, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 3404343.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 2m 36s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 41s View ↗

☁️ Nx Cloud last updated this comment at 2025-05-12 04:41:26 UTC

@lachlancollins lachlancollins changed the title test(react-query): initiate queryClient in beforeEach test(react-query): initialisee queryClient in beforeEach May 12, 2025
@lachlancollins lachlancollins changed the title test(react-query): initialisee queryClient in beforeEach test(react-query): initialise queryClient in beforeEach May 12, 2025
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented May 12, 2025

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@9142

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@9142

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@9142

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@9142

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@9142

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@9142

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@9142

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@9142

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@9142

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@9142

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@9142

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@9142

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@9142

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@9142

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@9142

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@9142

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@9142

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@9142

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@9142

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@9142

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@9142

commit: 3404343

@github-actions GitHub Actions
Copy link

Sizes for commit 3404343:

Branch Bundle Size
Main
This PR

@codecov Codecov
Copy link

codecov bot commented May 12, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.01%. Comparing base (4b0f79f) to head (3404343).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #9142       +/-   ##
===========================================
+ Coverage   44.49%   84.01%   +39.52%     
===========================================
  Files         206       25      -181     
  Lines        8150      369     -7781     
  Branches     1823      110     -1713     
===========================================
- Hits         3626      310     -3316     
+ Misses       4081       50     -4031     
+ Partials      443        9      -434
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental ∅ <ø> (∅)
@tanstack/eslint-plugin-query ∅ <ø> (∅)
@tanstack/query-async-storage-persister ∅ <ø> (∅)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods ∅ <ø> (∅)
@tanstack/query-core ∅ <ø> (∅)
@tanstack/query-devtools ∅ <ø> (∅)
@tanstack/query-persist-client-core ∅ <ø> (∅)
@tanstack/query-sync-storage-persister ∅ <ø> (∅)
@tanstack/query-test-utils ∅ <ø> (∅)
@tanstack/react-query 95.34% <ø> (ø)
@tanstack/react-query-devtools 10.00% <ø> (ø)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client 100.00% <ø> (ø)
@tanstack/solid-query ∅ <ø> (∅)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client ∅ <ø> (∅)
@tanstack/svelte-query ∅ <ø> (∅)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client ∅ <ø> (∅)
@tanstack/vue-query ∅ <ø> (∅)
@tanstack/vue-query-devtools ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lachlancollins lachlancollins merged commit 6a52926 into main May 12, 2025
7 checks passed
@lachlancollins lachlancollins deleted the fix-beforeeach branch May 12, 2025 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
package: react-query
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lachlancollins