fix(react-query): update Incorrect Inference of GetDefinedOrUndefinedQueryResult when TData is assignable to CallableFunction #9278
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR resolves an issue that was brought up in discord where using
queryOptions
where TQueryFnData was{ name: string }
, would cause the type of TData onuseQueries
to be{ name: string }
instead of{ name: string } | undefined
.Upon further investigation into what was causing this, it looks like because
InitialData
is assignabled to{ name: string }
when it is a function (since name is a key on CallableFunction in typescript), the type would assume the wrong pathway in theGetDefinedOrUndefinedQueryResult
type, resulting in the incorrect return type.Changing the initial condition from
T extends { initialData?: ... }
toT extends { initialData: ... }
allows us to avoid hitting that pathway altogether and gives the correct type.Tests
I have updated the tests to ensure this case is correctly tested against, and ensured that existing tests are not affected. I have also slightly restructured the tests specifically testing
queryOptions
under a describe for better code organization.Original Issue
Discord Thread: https://discord.com/channels/719702312431386674/1382540005624512532