Skip to content

test(svelte-query/createMutation): switch to fake timers, replace 'waitFor' with 'vi.waitFor', and add 'expect' #9382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 11, 2025
Merged

test(svelte-query/createMutation): switch to fake timers, replace 'waitFor' with 'vi.waitFor', and add 'expect' #9382

merged 2 commits into from
Jul 11, 2025
+48 −20

Conversation

sukvvon
Copy link
Contributor

@sukvvon sukvvon commented Jul 7, 2025

No description provided.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jul 7, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 6a2934d

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 1m 19s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 2s View ↗

☁️ Nx Cloud last updated this comment at 2025-07-11 05:03:28 UTC

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jul 7, 2025 •
edited
Loading

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@9382

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@9382

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@9382

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@9382

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@9382

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@9382

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@9382

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@9382

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@9382

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@9382

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@9382

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@9382

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@9382

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@9382

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@9382

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@9382

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@9382

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@9382

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@9382

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@9382

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@9382

commit: 6a2934d

@codecov Codecov
Copy link

codecov bot commented Jul 7, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.53%. Comparing base (b32904c) to head (6a2934d).
Report is 7 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #9382       +/-   ##
===========================================
+ Coverage   45.39%   89.53%   +44.14%     
===========================================
  Files         208       18      -190     
  Lines        8279      172     -8107     
  Branches     1861       31     -1830     
===========================================
- Hits         3758      154     -3604     
+ Misses       4080       17     -4063     
+ Partials      441        1      -440
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental ∅ <ø> (∅)
@tanstack/eslint-plugin-query ∅ <ø> (∅)
@tanstack/query-async-storage-persister ∅ <ø> (∅)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods ∅ <ø> (∅)
@tanstack/query-core ∅ <ø> (∅)
@tanstack/query-devtools ∅ <ø> (∅)
@tanstack/query-persist-client-core ∅ <ø> (∅)
@tanstack/query-sync-storage-persister ∅ <ø> (∅)
@tanstack/query-test-utils ∅ <ø> (∅)
@tanstack/react-query ∅ <ø> (∅)
@tanstack/react-query-devtools ∅ <ø> (∅)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client ∅ <ø> (∅)
@tanstack/solid-query ∅ <ø> (∅)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client ∅ <ø> (∅)
@tanstack/svelte-query 88.07% <ø> (ø)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client 100.00% <ø> (ø)
@tanstack/vue-query ∅ <ø> (∅)
@tanstack/vue-query-devtools ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sukvvon sukvvon changed the title test(svelte-query/createMutation): switch to fake timers , replace 'waitFor' with 'vi.waitFor' and add 'expect' test(svelte-query/createMutation): switch to fake timers, replace 'waitFor' with 'vi.waitFor', and add 'expect' Jul 7, 2025
@sukvvon sukvvon force-pushed the test/svelte-query-createMutation-fake-timers-vi-waitFor branch from f780059 to d6feb96 Compare July 7, 2025 10:12
@TkDodo TkDodo merged commit d6930fd into TanStack:main Jul 11, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
package: svelte-query
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sukvvon @TkDodo @manudeli