Skip to content

Conversation

sukvvon
Copy link
Contributor

@sukvvon sukvvon commented Oct 6, 2025

🎯 Changes

Updates the PR template checklist to use the explicit pnpm run syntax for consistency with the rest of the project.

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested this code locally with pnpm test:pr.

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

  • Documentation

    • Updated the pull request template checklist to clarify how contributors run local tests, improving guidance and reducing confusion during PR preparation.
  • Chores

    • No user-facing changes; application behavior, performance, and compatibility remain unchanged.
    • No configuration updates or migrations required.
    • No action needed from end-users.

Copy link

changeset-bot bot commented Oct 6, 2025

⚠️ No Changeset found

Latest commit: 7c4556c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

coderabbitai bot commented Oct 6, 2025

Walkthrough

The pull request updates the PR template checklist to change a command reference from pnpm test:pr to pnpm run test:pr in .github/pull_request_template.md. No code or logic is modified elsewhere.

Changes

Cohort / File(s) Summary
PR Template
/.github/pull_request_template.md
Updated checklist command from pnpm test:pr to pnpm run test:pr.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

I twitch my nose at docs so neat,
A tiny tweak—now tests compete!
With “run” we hop, no time to lag,
The pipelines cheer, they wag their flag.
Carrot-shaped checkmarks? Complete! 🥕✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title Check ✅ Passed The title clearly and concisely summarizes the primary change by indicating that the pull request template’s test command is being updated to use an explicit pnpm run invocation within the docs scope. It is specific, relevant, and follows conventional commit formatting with a type and scope.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
Description Check ✅ Passed The pull request description adheres to the repository’s template by providing a concise “🎯 Changes” section explaining the update, a completed “✅ Checklist” with the contributing guide and local test steps marked, and a “🚀 Release Impact” section correctly indicating a docs/CI/dev-only change.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

nx-cloud bot commented Oct 6, 2025

View your CI Pipeline Execution ↗ for commit 7c4556c

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 52s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 1s View ↗

☁️ Nx Cloud last updated this comment at 2025-10-09 02:16:57 UTC

Copy link

pkg-pr-new bot commented Oct 6, 2025

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@9733

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@9733

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@9733

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@9733

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@9733

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@9733

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@9733

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@9733

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@9733

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@9733

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@9733

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@9733

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@9733

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@9733

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@9733

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@9733

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@9733

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@9733

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@9733

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@9733

commit: 7c4556c

@sukvvon sukvvon marked this pull request as ready for review October 6, 2025 11:56
@TkDodo TkDodo merged commit ee85d16 into TanStack:main Oct 13, 2025
7 checks passed
Hellol77 pushed a commit to Hellol77/query that referenced this pull request Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants