Skip to content

fix(query-core): align focusManager with batching and error handling #9840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
+6 −3
Closed

fix(query-core): align focusManager with batching and error handling #9840

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c72b84
fix(query-core): align focusManager with batching and error handling
LeDevNovice Nov 2, 2025
bc84d95
fix: remove try catch handling to keep consistency
LeDevNovice Nov 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions packages/query-core/src/focusManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { Subscribable } from './subscribable'
import { isServer } from './utils'
import { notifyManager } from './notifyManager'

type Listener = (focused: boolean) => void

Expand Down Expand Up @@ -38,7 +39,7 @@ export class FocusManager extends Subscribable<Listener> {
}
}

protected onUnsubscribe() {
protected onUnsubscribe(): void {
if (!this.hasListeners()) {
this.#cleanup?.()
this.#cleanup = undefined
Expand Down Expand Up @@ -67,8 +68,10 @@ export class FocusManager extends Subscribable<Listener> {

onFocus(): void {
const isFocused = this.isFocused()
this.listeners.forEach((listener) => {
listener(isFocused)
notifyManager.batch(() => {
this.listeners.forEach((listener) => {
listener(isFocused)
})
})
}

Expand Down