Skip to content

Cast min and max argument when Dates to get rid of TS error #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: beta
Choose a base branch
from
Open

Cast min and max argument when Dates to get rid of TS error #240

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ea3e08
Cast min and max argument when Dates to get rid of TS error
Brodzko Aug 10, 2021
8c0bcb1
Output TS version during build
Brodzko Aug 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"build:commonjs": "rimraf ./lib && cross-env BABEL_ENV=commonjs babel --extensions .ts,.tsx --ignore ./src/**/tests/**/* ./src --out-dir lib",
"build:es": "rimraf ./es && babel --extensions .ts,.tsx --ignore ./src/**/tests/**/* ./src --out-dir es",
"build:umd": "rimraf ./dist && cross-env NODE_ENV=production rollup -c && rollup-plugin-visualizer stats-react.json",
"build:types": "rimraf ./types && tsc --project ./tsconfig.types.json && replace 'import type' 'import' ./types -r --silent && replace 'export type' 'export' ./types -r --silent",
"build:types": "rimraf ./types && tsc --version && tsc --project ./tsconfig.types.json && replace 'import type' 'import' ./types -r --silent && replace 'export type' 'export' ./types -r --silent",
"watch": "yarn watch:commonjs & yarn watch:es & yarn watch:umd & yarn watch:types",
"watch:commonjs": "rimraf ./lib && cross-env BABEL_ENV=commonjs babel --watch --extensions .ts,.tsx --ignore ./src/**/tests/**/* ./src --out-dir lib",
"watch:es": "rimraf ./es && babel --watch --extensions .ts,.tsx --ignore ./src/**/tests/**/* ./src --out-dir es",
Expand Down
4 changes: 2 additions & 2 deletions src/utils/buildAxis.linear.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,12 +122,12 @@ function buildTimeAxis<TDatum>(

// see https://stackoverflow.com/a/2831422
if (Object.prototype.toString.call(options.min) === '[object Date]') {
minValue = min([options.min, minValue as Date])
minValue = min([options.min, minValue] as Date[])
shouldNice = false
}

if (Object.prototype.toString.call(options.max) === '[object Date]') {
maxValue = max([options.max, maxValue as Date])
maxValue = max([options.max, maxValue] as Date[])
shouldNice = false
}

Expand Down