Repository navigation
Conversation
🦋 Changeset detectedLatest commit: f8e9baa The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Metadata parent eligibility packages/redact/src/dom/document-metadata.ts |
Metadata-parent selection supports eligible titles in element containers. It excludes itemProp elements, portal ancestry, and SVG contexts outside foreignObject. |
Title placement, hydration, and validation packages/redact/src/dom/reconcile.ts, packages/redact/src/dom/features/hydration/full.ts, tests/element-root-title.test.tsx, .changeset/tidy-element-titles.md |
Placement inserts an element-root title before an existing direct title. Hydration checks for a projected metadata parent only for document roots. Tests cover title updates, restoration, hydration, alternate document ownership, and excluded contexts. |
Estimated code review effort: 3 (Moderate) | ~20 minutes
Change: Bug fix
Suggested reviewers: tannerlinsley
Merge Risk: 
Minimal · up to f8e9b
-
No actionable merge-blocking correctness or availability risk is established by the reviewed change.
Pre-merge checks: 
5
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Fix
<title>handling forcreateRoot(element). In Redact 0.2.1, the title stays in the body, sodocument.titlestill shows the title fromindex.html. React 19.3.0 moves the rendered title into the head.StackBlitz reproduction · Source
Click Read document.title, then Change title and read it again. The component changes its title from
Page AtoPage B, but Redact keeps reportingStatic shell title. Runpnpm reactinstead ofpnpm startto compare with React.Changes
itemProp, and portal exclusions.Validation
Checked against
mainat20f6dd6with Node 24.22.0:Page A → Page B → Static shell title → Page A.Size
The size check still fails for the four entries below, so this remains a draft. Size limits are unchanged.
Implementation and tests prepared with GPT-6.1 Terra.
Summary by CodeRabbit
foreignObjectelements. Titles in certain SVG, portal, oritemPropcontexts remain in place.