remove extra comments #5946

tannerlinsley · 2025-11-22T20:31:55Z

Summary by CodeRabbit

Refactor
- Removed redundant documentation comments across router packages; no runtime behavior changes.
Breaking Changes
- Removed deprecated overloads for blocking/navigation APIs; migrate to the current parameter form.
- Several previously-exported internal utilities and a public session-type were removed, reducing the public API surface — update integrations to rely on remaining public APIs.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

coderabbitai · 2025-11-22T20:32:06Z

Walkthrough

This PR removes numerous JSDoc/comment blocks and deletes several exported types, interfaces, functions, and a class across react-router, router-core, solid-router, and start-server-core. No runtime logic changes were made; changes primarily reduce public API surface and clean up documentation.

Changes

Cohort / File(s)	Summary
JSDoc Removal (react-router) `packages/react-router/src/ClientOnly.tsx`, `packages/react-router/src/HeadContent.tsx`, `packages/react-router/src/Matches.tsx`, `packages/react-router/src/RouterProvider.tsx`, `packages/react-router/src/Scripts.tsx`, `packages/react-router/src/awaited.tsx`, `packages/react-router/src/fileRoute.ts`, `packages/react-router/src/router.ts`, `packages/react-router/src/useLoaderData.tsx`, `packages/react-router/src/useLoaderDeps.tsx`, `packages/react-router/src/useLocation.tsx`, `packages/react-router/src/useParams.tsx`, `packages/react-router/src/useRouter.tsx`, `packages/react-router/src/useRouterState.tsx`, `packages/react-router/src/useSearch.tsx`	Removed JSDoc / docblock comments above exported functions/components; implementations and signatures unchanged.
API Change (react-router) `packages/react-router/src/useBlocker.tsx`	Removed deprecated positional overload `useBlocker(blockerFn?: LegacyBlockerFn, condition?: boolean
JSDoc Removal (router-core) `packages/router-core/src/qss.ts`, `packages/router-core/src/redirect.ts`, `packages/router-core/src/scroll-restoration.ts`, `packages/router-core/src/searchMiddleware.ts`, `packages/router-core/src/searchParams.ts`	Removed explanatory JSDoc blocks; no behavioral or signature changes.
API Removal (router-core - types) `packages/router-core/src/Matches.ts`	Deleted exported interface `MatchRouteOptions`.
API Removal (router-core - route processing) `packages/router-core/src/new-process-route-tree.ts`	Removed exported helpers: `parseSegment`, `parseSegments`, `createDynamicNode`, `findFlatMatch`, `findSingleMatch`, and `processRouteTree`.
API Removal (router-core - path) `packages/router-core/src/path.ts`	Removed exported function `exactPathTest`.
API Removal (router-core - core router) `packages/router-core/src/router.ts`	Removed exported `getLocationChangeInfo`, `RouterCore` class, `lazyFn` helper, and `getMatchedRoutes` function.
API Consolidation (solid-router) `packages/solid-router/src/useBlocker.tsx`	Collapsed two deprecated `useBlocker` overloads into a single unified overload accepting `UseBlockerOpts
Type Removal (start-server-core) `packages/start-server-core/src/session.ts`	Removed exported type `SealOptions` (`SealOptionsSub` remains).

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~60 minutes

Areas needing extra attention:
- packages/router-core/src/router.ts — removal of RouterCore, getLocationChangeInfo, getMatchedRoutes, and lazyFn.
- packages/router-core/src/new-process-route-tree.ts — removal of multiple route-processing helpers.
- Type/API compatibility for useBlocker changes in both react- and solid-router.
- packages/start-server-core/src/session.ts — verify downstream type usage after SealOptions removal.

Possibly related PRs

refactor(router-core): Process routeTree into segment tree instead of flatRoutes #5722 — Refactor of route-processing / segment-based pipeline that overlaps removals of processRouteTree, parseSegment, and related helpers.
refactor(router-core): processRouteTree in its own file #5128 — Moves/refactors processRouteTree and related router-core functions; directly relevant to removed exports.
fix: various fixes #5593 — Consolidates/removes deprecated useBlocker overloads in solid-router; closely related to the overload removals here.

Suggested reviewers

schiller-manuel
SeanCassiere

Poem

🐰 With nimble paws I cleared the lea,
Docblocks swept and types set free.
Old overloads hopped off to rest,
The router trims its vest — and best,
It bounds ahead, all spry and bright. ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'remove extra comments' accurately reflects the primary change across all files—removal of duplicate/redundant JSDoc blocks and documentation comments throughout multiple packages.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch fix/remove-extra-comments

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6ac4af7 and acf36f0.

📒 Files selected for processing (2)

packages/react-router/src/fileRoute.ts (0 hunks)
packages/router-core/src/scroll-restoration.ts (0 hunks)

💤 Files with no reviewable changes (2)

packages/react-router/src/fileRoute.ts
packages/router-core/src/scroll-restoration.ts

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: Test

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

nx-cloud · 2025-11-22T20:32:22Z

🤖 Nx Cloud AI Fix Eligible

An automatically generated fix could have helped fix failing tasks for this run, but Self-healing CI is disabled for this workspace. Visit workspace settings to enable it and get automatic fixes in future runs.

_{To disable these notifications, a workspace admin can disable them in workspace settings.}

View your CI Pipeline Execution ↗ for commit acf36f0

Command	Status	Duration	Result
`nx affected --targets=test:eslint,test:unit,tes...`	❌ Failed	1m 59s	View ↗
`nx run-many --target=build --exclude=examples/*...`	❌ Failed	4s	View ↗

☁️ Nx Cloud last updated this comment at 2025-11-22 20:40:08 UTC

schiller-manuel · 2025-11-22T20:33:27Z

packages/react-router/src/fileRoute.ts

 * @returns A function that accepts Route options and returns a Route instance.
 * @link https://tanstack.com/router/latest/docs/framework/react/api/router/createFileRouteFunction
 */
-/**


this still has duplicated jsdocs

schiller-manuel · 2025-11-22T20:33:57Z

packages/react-router/src/fileRoute.ts

@@ -292,18 +276,6 @@
  }


schiller-manuel · 2025-11-22T20:39:02Z

packages/react-router/src/fileRoute.ts

@@ -1,4 +1,3 @@
-/* eslint-disable react-hooks/rules-of-hooks */


dont remove this

schiller-manuel · 2025-11-22T20:39:52Z

packages/react-router/src/Matches.tsx

still duplicate

schiller-manuel · 2025-11-22T20:41:12Z

packages/router-core/src/new-process-route-tree.ts

  5: number
 }

-/**


dont remove that!

schiller-manuel · 2025-11-22T20:41:21Z

packages/router-core/src/new-process-route-tree.ts

  return output as ParsedSegment
 }

-/**


dont remove that!

schiller-manuel · 2025-11-22T20:41:28Z

packages/router-core/src/new-process-route-tree.ts

  }
 }

-/**


dont remove that

schiller-manuel · 2025-11-22T20:41:36Z

packages/router-core/src/new-process-route-tree.ts

  >(1000)
 }

-/**


dont remove that

schiller-manuel · 2025-11-22T20:41:41Z

packages/router-core/src/new-process-route-tree.ts

  return result
 }

-/**


dont remove that

schiller-manuel · 2025-11-22T20:41:50Z

packages/router-core/src/new-process-route-tree.ts

  return path === '/' ? path : path.replace(/\/{1,}$/, '')
 }

-/**


dont remove that

schiller-manuel · 2025-11-22T20:42:18Z

packages/router-core/src/path.ts

  cache?: LRUCache<string, string>
 }

-/**


dont remove that

schiller-manuel · 2025-11-22T20:42:53Z

packages/router-core/src/router.ts

 export type TrailingSlashOption =
  (typeof trailingSlashOptions)[keyof typeof trailingSlashOptions]

-/**


dont remove that

schiller-manuel · 2025-11-22T20:43:01Z

packages/router-core/src/router.ts

  TDehydrated
 >

-/**


dont remove that

schiller-manuel · 2025-11-22T20:43:05Z

packages/router-core/src/router.ts

  return normalize(a) === normalize(b)
 }

-/**


dont remove that

schiller-manuel · 2025-11-22T20:43:15Z

packages/router-core/src/router.ts

  return {}
 }

-/**


dont remove that

schiller-manuel · 2025-11-22T20:43:45Z

packages/start-server-core/src/session.ts

 type IntegrityAlgorithm = 'sha256'
 /** @internal */
 type _Algorithm = EncryptionAlgorithm | IntegrityAlgorithm
-/**


dont remove that

remove extra comments

6ac4af7

tannerlinsley requested a review from schiller-manuel November 22, 2025 20:31

github-actions bot added package: react-router package: router-core package: solid-router package: start-server-core labels Nov 22, 2025