Skip to content

feat(table-core): fix API to calculate max expanded row depth #6120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
+11 −2
Open

feat(table-core): fix API to calculate max expanded row depth #6120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
88ea0e8
WIP: My RowExpanding.ts fix
Oct 24, 2025
207f890
Update packages/table-core/src/features/RowExpanding.ts
ugjjffu Oct 24, 2025
79797d1
Delete examples/react/basic/src/data.ts
ugjjffu Oct 24, 2025
15f4c80
add changeset
Oct 24, 2025
5c43c9c
Merge branch 'fix/row-expanding-bug' of https://github.com/ugjjffu/ta…
Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/every-grapes-judge.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@tanstack/table-core': major
---

fix API to calculate max expanded row depth
8 changes: 6 additions & 2 deletions packages/table-core/src/features/RowExpanding.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,8 +311,12 @@ export const RowExpanding: TableFeature = {
}

if (exists && !expanded) {
const { [row.id]: _, ...rest } = oldExpanded
return rest
return Object.keys(oldExpanded).reduce((acc, rowId) => {
if (rowId !== row.id && !rowId.startsWith(row.id + '.')) {
acc[rowId] = oldExpanded[rowId];
}
return acc;
}, {} as ExpandedStateList);
}

return old
Expand Down