Skip to content

fix(virtual-core): update maybeNotify cache when deps change #957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 13, 2025
Merged

fix(virtual-core): update maybeNotify cache when deps change #957

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f9e5bb8
fix(virtual-core): update maybeNotify cache when deps change
piecyk Mar 13, 2025
ce47261
Add changeset
piecyk Mar 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/mean-lamps-shake.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@tanstack/virtual-core': patch
---

fix(virtual-core): update maybeNotify cache when deps change
1 change: 1 addition & 0 deletions packages/virtual-core/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -734,6 +734,7 @@ export class Virtualizer<
startIndex = range.startIndex
endIndex = range.endIndex
}
this.maybeNotify.updateDeps([this.isScrolling, startIndex, endIndex])
return [
this.options.rangeExtractor,
this.options.overscan,
Expand Down
9 changes: 8 additions & 1 deletion packages/virtual-core/src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export function memo<TDeps extends ReadonlyArray<any>, TResult>(
let deps = opts.initialDeps ?? []
let result: TResult | undefined

return (): TResult => {
function memoizedFunction(): TResult {
let depTime: number
if (opts.key && opts.debug?.()) depTime = Date.now()

Expand Down Expand Up @@ -66,6 +66,13 @@ export function memo<TDeps extends ReadonlyArray<any>, TResult>(

return result
}

// Attach updateDeps to the function itself
memoizedFunction.updateDeps = (newDeps: [...TDeps]) => {
deps = newDeps
}

return memoizedFunction
}

export function notUndefined<T>(value: T | undefined, msg?: string): T {
Expand Down