Skip to content

feature/remove-team-member#114

Merged
mdawoud27 merged 5 commits into
mainfrom
feature/113/remove_team_member
Apr 7, 2025
Merged

feature/remove-team-member#114
mdawoud27 merged 5 commits into
mainfrom
feature/113/remove_team_member

Conversation

@mdawoud27
Copy link
Copy Markdown
Contributor

PR Checklist (required)

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.

  • Tests for the changes have been added (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation changes
  • Other... Please describe:

Related Issue

Closes #113

@mdawoud27 mdawoud27 added documentation Improvements or additions to documentation enhancement New feature or request feature For new feature labels Apr 7, 2025
@mdawoud27 mdawoud27 requested a review from Copilot April 7, 2025 21:15
@mdawoud27 mdawoud27 self-assigned this Apr 7, 2025
@mdawoud27 mdawoud27 linked an issue Apr 7, 2025 that may be closed by this pull request
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 6 changed files in this pull request and generated 1 comment.

Files not reviewed (3)
  • prisma/migrations/20250407182922_add_delete_at_to_team_member_model/migration.sql: Language not supported
  • prisma/schema/models/team.model.prisma: Language not supported
  • src/docs/swagger.json: Language not supported
Comments suppressed due to low confidence (1)

src/controllers/team.controller.js:419

  • [nitpick] Consider validating the format of each ID (e.g. using regex for UUID validation) to ensure they conform to expected patterns, which may help prevent downstream errors.
if (!organizationId || !departmentId || !teamId || !memberId) {

Comment thread src/controllers/team.controller.js
@mdawoud27 mdawoud27 merged commit a0b778b into main Apr 7, 2025
11 checks passed
@mdawoud27 mdawoud27 deleted the feature/113/remove_team_member branch April 7, 2025 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request feature For new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE]: Remove a team member

2 participants