Skip to content

feature/update-project#132

Merged
mdawoud27 merged 5 commits into
mainfrom
feature/131/update_project
Apr 12, 2025
Merged

feature/update-project#132
mdawoud27 merged 5 commits into
mainfrom
feature/131/update_project

Conversation

@mdawoud27
Copy link
Copy Markdown
Contributor

PR Checklist (required)

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.

  • Tests for the changes have been added (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation changes
  • Other... Please describe:

Related Issue

Closes #131

@mdawoud27 mdawoud27 added documentation Improvements or additions to documentation feature For new feature labels Apr 12, 2025
@mdawoud27 mdawoud27 requested a review from Copilot April 12, 2025 16:21
@mdawoud27 mdawoud27 self-assigned this Apr 12, 2025
@mdawoud27 mdawoud27 linked an issue Apr 12, 2025 that may be closed by this pull request
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • src/docs/swagger.json: Language not supported
Comments suppressed due to low confidence (2)

src/validations/project.validation.js:111

  • Verify that Joi.date().iso() triggers a 'date.format' error code; if not, consider updating the message key to match the actual error code returned by the validator.
      'date.format': 'Start date must be in ISO format (YYYY-MM-DD)',

src/controllers/project.controller.js:465

  • Ensure that projectId's data type matches the expected type in your data model (for example, converting it to a number if required) to avoid unexpected mismatches during the duplicate check.
            id: { not: projectId },

@mdawoud27 mdawoud27 merged commit cc3f5f0 into main Apr 12, 2025
11 checks passed
@mdawoud27 mdawoud27 deleted the feature/131/update_project branch April 12, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation feature For new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE]: Update a project

2 participants