Skip to content

feature/update-task#152

Merged
mdawoud27 merged 7 commits into
mainfrom
feature/151/update_task
Apr 17, 2025
Merged

feature/update-task#152
mdawoud27 merged 7 commits into
mainfrom
feature/151/update_task

Conversation

@mdawoud27
Copy link
Copy Markdown
Contributor

PR Checklist (required)

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.

  • Tests for the changes have been added (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation changes
  • Other... Please describe:

Related Issue

Closes #151

@mdawoud27 mdawoud27 added documentation Improvements or additions to documentation enhancement New feature or request feature For new feature labels Apr 17, 2025
@mdawoud27 mdawoud27 requested a review from Copilot April 17, 2025 17:25
@mdawoud27 mdawoud27 self-assigned this Apr 17, 2025
@mdawoud27 mdawoud27 linked an issue Apr 17, 2025 that may be closed by this pull request
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new feature to update tasks by adding an update validation schema, new update route, and a corresponding controller function. The key changes include:

  • Introducing the updateTaskValidation schema with validations for task properties.
  • Adding a new PUT route for updating tasks.
  • Implementing the updateTask controller with validation, permission checks, and circular dependency handling.
  • Updating README documentation to include the update route.

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

File Description
src/validations/task.validation.js Added updateTaskValidation schema with various field validations.
src/routes/task.routes.js Registered a new PUT route for task updates.
src/controllers/task.controller.js Implemented updateTask controller to handle task updates.
README.md Updated API documentation to include instructions for updating a task.
Files not reviewed (1)
  • src/docs/swagger.json: Language not supported
Comments suppressed due to low confidence (1)

src/controllers/task.controller.js:373

  • The updateTaskValidation schema includes additional fields ('rate', 'order') that are not extracted or updated in the controller. Consider either handling these fields in the updateTask function or removing them from the validation schema to maintain consistency.
const { title, description, priority, sprintId, assignedTo, dueDate, estimatedTime, parentId, labels } = req.body;

Comment thread src/controllers/task.controller.js
@mdawoud27 mdawoud27 merged commit d0eb3a0 into main Apr 17, 2025
11 checks passed
@mdawoud27 mdawoud27 deleted the feature/151/update_task branch April 17, 2025 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request feature For new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE]: Update a task

2 participants